* [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core'
@ 2023-08-25 19:16 kernel test robot
2023-08-25 20:09 ` Nick Desaulniers
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2023-08-25 19:16 UTC (permalink / raw)
To: Nick Desaulniers; +Cc: llvm, oe-kbuild-all, Michael Ellerman, Nathan Chancellor
tree: https://github.com/linuxppc/linux next-test
head: c37b6908f7b2bd24dcaaf14a180e28c9132b9c58
commit: 7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb [85/129] Revert "powerpc/xmon: Relax frame size for clang"
config: powerpc64-randconfig-r006-20230825 (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308260344.Vc4Giuk7-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core' [-Werror,-Wframe-larger-than]
static int xmon_core(struct pt_regs *regs, volatile int fromipi)
^
1 error generated.
vim +/xmon_core +489 arch/powerpc/xmon/xmon.c
5c699396f5f6cf arch/powerpc/xmon/xmon.c Anton Blanchard 2020-06-30 488
a2305e3de81939 arch/powerpc/xmon/xmon.c Arnd Bergmann 2021-04-29 @489 static int xmon_core(struct pt_regs *regs, volatile int fromipi)
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 490 {
a2305e3de81939 arch/powerpc/xmon/xmon.c Arnd Bergmann 2021-04-29 491 volatile int cmd = 0;
a2305e3de81939 arch/powerpc/xmon/xmon.c Arnd Bergmann 2021-04-29 492 struct bpt *volatile bp;
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 493 long recurse_jmp[JMP_BUF_LEN];
69393cb03ccdf2 arch/powerpc/xmon/xmon.c Christopher M. Riedl 2019-09-07 494 bool locked_down;
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 495 unsigned long offset;
f13659e0b39075 arch/powerpc/xmon/xmon.c Anton Blanchard 2007-03-21 496 unsigned long flags;
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 497 #ifdef CONFIG_SMP
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 498 int cpu;
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 499 int secondary;
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 500 #endif
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 501
f13659e0b39075 arch/powerpc/xmon/xmon.c Anton Blanchard 2007-03-21 502 local_irq_save(flags);
a71d64b4dc4067 arch/powerpc/xmon/xmon.c Anton Blanchard 2014-08-05 503 hard_irq_disable();
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 504
69393cb03ccdf2 arch/powerpc/xmon/xmon.c Christopher M. Riedl 2019-09-07 505 locked_down = xmon_is_locked_down();
69393cb03ccdf2 arch/powerpc/xmon/xmon.c Christopher M. Riedl 2019-09-07 506
aaf06665f7ea3e arch/powerpc/xmon/xmon.c Naveen N. Rao 2019-06-27 507 if (!fromipi) {
ed49f7fd6438dc arch/powerpc/xmon/xmon.c Breno Leitao 2017-08-02 508 tracing_enabled = tracing_is_on();
ed49f7fd6438dc arch/powerpc/xmon/xmon.c Breno Leitao 2017-08-02 509 tracing_off();
aaf06665f7ea3e arch/powerpc/xmon/xmon.c Naveen N. Rao 2019-06-27 510 }
ed49f7fd6438dc arch/powerpc/xmon/xmon.c Breno Leitao 2017-08-02 511
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 512 bp = in_breakpoint_table(regs->nip, &offset);
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 513 if (bp != NULL) {
59dc5bfca0cb6a arch/powerpc/xmon/xmon.c Nicholas Piggin 2021-06-18 514 regs_set_return_ip(regs, bp->address + offset);
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 515 atomic_dec(&bp->ref_count);
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 516 }
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 517
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 518 remove_cpu_bpts();
^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 519
:::::: The code at line 489 was first introduced by commit
:::::: a2305e3de819394a7adf68078964a92d06f9db33 powerpc: mark local variables around longjmp as volatile
:::::: TO: Arnd Bergmann <arnd@arndb.de>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core'
2023-08-25 19:16 [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core' kernel test robot
@ 2023-08-25 20:09 ` Nick Desaulniers
2023-08-27 11:32 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2023-08-25 20:09 UTC (permalink / raw)
To: Michael Ellerman
Cc: llvm, oe-kbuild-all, Nathan Chancellor, kernel test robot
On Fri, Aug 25, 2023 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://github.com/linuxppc/linux next-test
> head: c37b6908f7b2bd24dcaaf14a180e28c9132b9c58
> commit: 7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb [85/129] Revert "powerpc/xmon: Relax frame size for clang"
> config: powerpc64-randconfig-r006-20230825 (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
Hi Michael,
Given this report and
https://github.com/ClangBuiltLinux/linux/issues/252#issuecomment-1690371256,
it seems that it's still possible to trigger this warning (and build
failure with CONFIG_WERROR). Is it possible to drop my patch at this
point?
I'll need to go back to the drawing board with these configs +
specific versions of clang to better understand what's going wrong
here. Sorry for the trouble.
> reproduce: (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308260344.Vc4Giuk7-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core' [-Werror,-Wframe-larger-than]
> static int xmon_core(struct pt_regs *regs, volatile int fromipi)
> ^
> 1 error generated.
>
>
> vim +/xmon_core +489 arch/powerpc/xmon/xmon.c
>
> 5c699396f5f6cf arch/powerpc/xmon/xmon.c Anton Blanchard 2020-06-30 488
> a2305e3de81939 arch/powerpc/xmon/xmon.c Arnd Bergmann 2021-04-29 @489 static int xmon_core(struct pt_regs *regs, volatile int fromipi)
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 490 {
> a2305e3de81939 arch/powerpc/xmon/xmon.c Arnd Bergmann 2021-04-29 491 volatile int cmd = 0;
> a2305e3de81939 arch/powerpc/xmon/xmon.c Arnd Bergmann 2021-04-29 492 struct bpt *volatile bp;
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 493 long recurse_jmp[JMP_BUF_LEN];
> 69393cb03ccdf2 arch/powerpc/xmon/xmon.c Christopher M. Riedl 2019-09-07 494 bool locked_down;
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 495 unsigned long offset;
> f13659e0b39075 arch/powerpc/xmon/xmon.c Anton Blanchard 2007-03-21 496 unsigned long flags;
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 497 #ifdef CONFIG_SMP
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 498 int cpu;
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 499 int secondary;
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 500 #endif
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 501
> f13659e0b39075 arch/powerpc/xmon/xmon.c Anton Blanchard 2007-03-21 502 local_irq_save(flags);
> a71d64b4dc4067 arch/powerpc/xmon/xmon.c Anton Blanchard 2014-08-05 503 hard_irq_disable();
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 504
> 69393cb03ccdf2 arch/powerpc/xmon/xmon.c Christopher M. Riedl 2019-09-07 505 locked_down = xmon_is_locked_down();
> 69393cb03ccdf2 arch/powerpc/xmon/xmon.c Christopher M. Riedl 2019-09-07 506
> aaf06665f7ea3e arch/powerpc/xmon/xmon.c Naveen N. Rao 2019-06-27 507 if (!fromipi) {
> ed49f7fd6438dc arch/powerpc/xmon/xmon.c Breno Leitao 2017-08-02 508 tracing_enabled = tracing_is_on();
> ed49f7fd6438dc arch/powerpc/xmon/xmon.c Breno Leitao 2017-08-02 509 tracing_off();
> aaf06665f7ea3e arch/powerpc/xmon/xmon.c Naveen N. Rao 2019-06-27 510 }
> ed49f7fd6438dc arch/powerpc/xmon/xmon.c Breno Leitao 2017-08-02 511
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 512 bp = in_breakpoint_table(regs->nip, &offset);
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 513 if (bp != NULL) {
> 59dc5bfca0cb6a arch/powerpc/xmon/xmon.c Nicholas Piggin 2021-06-18 514 regs_set_return_ip(regs, bp->address + offset);
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 515 atomic_dec(&bp->ref_count);
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 516 }
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 517
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 518 remove_cpu_bpts();
> ^1da177e4c3f41 arch/ppc64/xmon/xmon.c Linus Torvalds 2005-04-16 519
>
> :::::: The code at line 489 was first introduced by commit
> :::::: a2305e3de819394a7adf68078964a92d06f9db33 powerpc: mark local variables around longjmp as volatile
>
> :::::: TO: Arnd Bergmann <arnd@arndb.de>
> :::::: CC: Michael Ellerman <mpe@ellerman.id.au>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core'
2023-08-25 20:09 ` Nick Desaulniers
@ 2023-08-27 11:32 ` Michael Ellerman
2023-08-28 17:39 ` Nick Desaulniers
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2023-08-27 11:32 UTC (permalink / raw)
To: Nick Desaulniers
Cc: llvm, oe-kbuild-all, Nathan Chancellor, kernel test robot
Nick Desaulniers <ndesaulniers@google.com> writes:
> On Fri, Aug 25, 2023 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
>>
>> tree: https://github.com/linuxppc/linux next-test
>> head: c37b6908f7b2bd24dcaaf14a180e28c9132b9c58
>> commit: 7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb [85/129] Revert "powerpc/xmon: Relax frame size for clang"
>> config: powerpc64-randconfig-r006-20230825 (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/config)
>> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
>
> Hi Michael,
> Given this report and
> https://github.com/ClangBuiltLinux/linux/issues/252#issuecomment-1690371256,
> it seems that it's still possible to trigger this warning (and build
> failure with CONFIG_WERROR). Is it possible to drop my patch at this
> point?
It's too late to drop it, so we'd need to do a revert.
But rather than just a straight revert maybe we can do something that's
more tightly focused, ie. just to specific Clang versions?
> I'll need to go back to the drawing board with these configs +
> specific versions of clang to better understand what's going wrong
> here. Sorry for the trouble.
No worries.
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core'
2023-08-27 11:32 ` Michael Ellerman
@ 2023-08-28 17:39 ` Nick Desaulniers
2023-08-29 23:29 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2023-08-28 17:39 UTC (permalink / raw)
To: Michael Ellerman
Cc: llvm, oe-kbuild-all, Nathan Chancellor, kernel test robot
On Sun, Aug 27, 2023 at 4:32 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Nick Desaulniers <ndesaulniers@google.com> writes:
> > On Fri, Aug 25, 2023 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
> >>
> >> tree: https://github.com/linuxppc/linux next-test
> >> head: c37b6908f7b2bd24dcaaf14a180e28c9132b9c58
> >> commit: 7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb [85/129] Revert "powerpc/xmon: Relax frame size for clang"
> >> config: powerpc64-randconfig-r006-20230825 (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/config)
> >> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
> >
> > Hi Michael,
> > Given this report and
> > https://github.com/ClangBuiltLinux/linux/issues/252#issuecomment-1690371256,
> > it seems that it's still possible to trigger this warning (and build
> > failure with CONFIG_WERROR). Is it possible to drop my patch at this
> > point?
>
> It's too late to drop it, so we'd need to do a revert.
Np. Sent: https://lore.kernel.org/llvm/20230828-ppc_rerevert-v1-1-74f55b818907@google.com/
>
> But rather than just a straight revert maybe we can do something that's
> more tightly focused, ie. just to specific Clang versions?
Seeing as the bot found a randconfig, I'm not confident that a version
check would be enough at this point.
Also, quite a few fires this Monday morning. I'd rather back this out
entirely and revisit it another day. I thought it would be a simple
revert; obviously not!
>
> > I'll need to go back to the drawing board with these configs +
> > specific versions of clang to better understand what's going wrong
> > here. Sorry for the trouble.
>
> No worries.
>
> cheers
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core'
2023-08-28 17:39 ` Nick Desaulniers
@ 2023-08-29 23:29 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2023-08-29 23:29 UTC (permalink / raw)
To: Nick Desaulniers
Cc: llvm, oe-kbuild-all, Nathan Chancellor, kernel test robot
Nick Desaulniers <ndesaulniers@google.com> writes:
> On Sun, Aug 27, 2023 at 4:32 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Nick Desaulniers <ndesaulniers@google.com> writes:
>> > On Fri, Aug 25, 2023 at 12:17 PM kernel test robot <lkp@intel.com> wrote:
>> >>
>> >> tree: https://github.com/linuxppc/linux next-test
>> >> head: c37b6908f7b2bd24dcaaf14a180e28c9132b9c58
>> >> commit: 7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb [85/129] Revert "powerpc/xmon: Relax frame size for clang"
>> >> config: powerpc64-randconfig-r006-20230825 (https://download.01.org/0day-ci/archive/20230826/202308260344.Vc4Giuk7-lkp@intel.com/config)
>> >> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
>> >
>> > Hi Michael,
>> > Given this report and
>> > https://github.com/ClangBuiltLinux/linux/issues/252#issuecomment-1690371256,
>> > it seems that it's still possible to trigger this warning (and build
>> > failure with CONFIG_WERROR). Is it possible to drop my patch at this
>> > point?
>>
>> It's too late to drop it, so we'd need to do a revert.
>
> Np. Sent: https://lore.kernel.org/llvm/20230828-ppc_rerevert-v1-1-74f55b818907@google.com/
Thanks.
>> But rather than just a straight revert maybe we can do something that's
>> more tightly focused, ie. just to specific Clang versions?
>
> Seeing as the bot found a randconfig, I'm not confident that a version
> check would be enough at this point.
Yeah fair enough.
> Also, quite a few fires this Monday morning. I'd rather back this out
> entirely and revisit it another day. I thought it would be a simple
> revert; obviously not!
No worries.
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-29 23:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 19:16 [linuxppc:next-test 85/129] arch/powerpc/xmon/xmon.c:489:12: error: stack frame size (2160) exceeds limit (2048) in 'xmon_core' kernel test robot
2023-08-25 20:09 ` Nick Desaulniers
2023-08-27 11:32 ` Michael Ellerman
2023-08-28 17:39 ` Nick Desaulniers
2023-08-29 23:29 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox