From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20A5C32AAD3; Tue, 4 Nov 2025 18:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762281378; cv=none; b=VENv3Wl2Iz491oQJmLuvZzy5Z8LYbZ+3yPQrWS8BRutV77V6VDFIjUt9Vo5C3+a/L7NibvJQU4+2Uh/5PrbKoQL2OZX4YwNL0PjjDzPahHCSh6D5Pgj59XseRpubq7RsA0NngHlh6/R2CTBBi6BWOvTs+xFz3cnK2hp6xoPptQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762281378; c=relaxed/simple; bh=SsPvEHwG7+8/hfYHq054WgBikVniVDmj7mpMjYb6Bm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YnsciO3BomAx5zpXxWmLN2Q/V5cw5flkgeYhYwJtiEiuRTi9q9QBq8tS/DgTTsgU7CESdjNaZszl+KUPF0yRadfL/5SqR5Tog6QRdwOhkwNwMSYm3aebKoV8SGD7CWyktg3PXPpsC1QPinhI/LwDhK5pjWx4rw0ALeC4O+mVxO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F3511CE0; Tue, 4 Nov 2025 10:36:07 -0800 (PST) Received: from [10.1.33.58] (010265703453.cambridge.arm.com [10.1.33.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 757A33F694; Tue, 4 Nov 2025 10:36:14 -0800 (PST) Message-ID: <8feac1c4-3bc8-4fa8-b2a7-6bbe0f790d73@arm.com> Date: Tue, 4 Nov 2025 18:36:12 +0000 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [arm-perf:for-next/perf 6/8] drivers/perf/arm-ni.c:433:13: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first To: Will Deacon Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev References: <202511041749.ok8zDP6u-lkp@intel.com> <5bba40c3-bfab-481d-8252-4f5a62e2b79e@arm.com> <3e9e655f-eccd-425f-a243-161e84d801a8@arm.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-11-04 6:24 pm, Will Deacon wrote: > On Tue, Nov 04, 2025 at 02:04:57PM +0000, Robin Murphy wrote: >> On 2025-11-04 1:32 pm, Will Deacon wrote: >>> On Tue, Nov 04, 2025 at 01:26:11PM +0000, Robin Murphy wrote: >>>> On 2025-11-04 12:35 pm, Will Deacon wrote: >>>>> On Tue, Nov 04, 2025 at 05:43:40PM +0800, kernel test robot wrote: >>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git for-next/perf >>>>>> head: 989b40b7578a2be7b0388522d33d751b257d59d9 >>>>>> commit: 8fa08f8835e57e1fd5e2994c9cf76c84dadc1235 [6/8] perf/arm-ni: Add NoC S3 support >>>>>> config: sparc64-randconfig-002-20251104 (https://download.01.org/0day-ci/archive/20251104/202511041749.ok8zDP6u-lkp@intel.com/config) >>>>>> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d2625a438020ad35330cda29c3def102c1687b1b) >>>>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251104/202511041749.ok8zDP6u-lkp@intel.com/reproduce) >>>>>> >>>>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>>>>> the same patch/commit), kindly add following tags >>>>>> | Reported-by: kernel test robot >>>>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202511041749.ok8zDP6u-lkp@intel.com/ >>>>>> >>>>>> All warnings (new ones prefixed by >>): >>>>>> >>>>>>>> drivers/perf/arm-ni.c:433:13: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Wparentheses] >>>>>> 432 | hw->event_base = (unsigned long)cd->pmu_base + >>>>>> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>> 433 | is_7xx ? NI700_PMCCNTR_L : NI_PMCCNTR_L; >>>>>> | ~~~~~~ ^ >>>>>> drivers/perf/arm-ni.c:433:13: note: place parentheses around the '+' expression to silence this warning >>>>>> 432 | hw->event_base = (unsigned long)cd->pmu_base + >>>>>> | ( >>>>>> 433 | is_7xx ? NI700_PMCCNTR_L : NI_PMCCNTR_L; >>>>>> | ^ >>>>>> | ) >>>>> >>>>> Hrm. Doesn't that mean this is completely broken or am I misreading the >>>>> report? >>>> >>>> Bah, my arm64 W=1 build (which I did do in the hope of catching any such >>>> sillies...) fails to flag that :( >>>> >>>> Truth is this is a fresh refactoring of the mess I originally wrote that got >>>> tested by someone else 18 months ago, and I don't have any hardware to >>>> functionally test it myself. Feel free to drop it and I'll send a complete >>>> v2, or I can do an incremental fix if you prefer (I already realised I could >>>> have streamlined the version check to a one-off in event_init as well.) >>> >>> Damn, it's not ideal that we don't have any test coverage for this. >>> >>> The patch is buried under some others now, so I can either revert it or >>> take fixes on top. Up to you. >> >> I've managed to break my git-send-email setup at the moment, so I hope >> an inline patch is OK! > > Sadly, this appears to be whitespace corrupted in a very strange way. The > version I see in mutt is different to the version on lore, which itself > renders differently when viewed as "raw". None of them apply :( Hooray for Office 365 and its liberal approximation of IMAP... Anyway, I have now managed to sort out the machine that was keeping me out of my other account, so you should have a properly-sent version now. Cheers, Robin.