Re: [PATCH v3 7/9] ARM: page: Turn highpage accesses into static inlines

[Linus Walleij <linus.walleij@linaro.org>]

On Mon, Mar 11, 2024 at 1:15 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> On Mon, 11 Mar 2024 at 10:15, Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > Clearing and copying pages in highmem uses either the cpu_user
> > vtable or the __glue() assembler stubs to call into per-CPU
> > versions of these functions.
> >
> > This is all really confusing for KCFI so wrap these into static
> > inlines and prefix each inline function with __nocfi.
> >
> > __cpu_clear_user_highpage() and __cpu_copy_user_highpage() are
> > exported in arch/arm/mm/proc-syms.c which causes a problem with
> > using static inlines, but it turns out that these exports are
> > completely unused, so we can just delete them.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >  arch/arm/include/asm/page.h | 36 +++++++++++++++++++++++++++++-------
> >  arch/arm/mm/proc-syms.c     |  7 +------
> >  2 files changed, 30 insertions(+), 13 deletions(-)
> >
>
> Are you sure this patch is needed?

It's not needed, it was a development artifact from fixing the highmem access
before fixing cache and TLB flush. The highmem code did a bunch of that.

Posting v4!

Yours,
Linus Walleij