From: Borislav Petkov <bp@alien8.de>
To: Philip Li <philip.li@intel.com>
Cc: kernel test robot <lkp@intel.com>,
Babu Moger <babu.moger@amd.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org, x86@kernel.org,
Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [tip:x86/cache 9/13] arch/x86/kernel/cpu/resctrl/rdtgroup.c:1456:6: warning: variable 'h' set but not used
Date: Thu, 9 Feb 2023 10:53:47 +0100 [thread overview]
Message-ID: <Y+TCq4k+0AhfjZkL@zn.tnic> (raw)
In-Reply-To: <Y+RjOpXP1Bbv268n@rli9-mobl>
On Thu, Feb 09, 2023 at 11:06:34AM +0800, Philip Li wrote:
> Thanks a lot for the suggestions, we will think of this to continuously optimize the
> service. Right now, we try to build-test the patches that we can find a suitable base
> to apply the patches successfully, some of effort could fail. Then we only test them
> when they appears on repo. We will keep monitoring the patch testing status to see
> anything we can fix as well.
Cool, thanks.
I see you've started doing silly tests like subdirectory builds for W=
warnings, picking one such report at random from lkml:
https://lore.kernel.org/r/202302091432.VgittDjI-lkp@intel.com
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/spi/
and then it says
drivers/spi/spi-mpc52xx-psc.c:195:5: warning: no previous prototype for 'mpc52xx_psc_spi_transfer_one_message' [-Wmissing-prototypes]
Yes, this is all fine and dandy but such tests should be the lowest prio
eva! If you have a way to schedule by prio, those should wait until all
the other build tests have happened.
I don't know how your resources are spread out and whether you even can
do as many so I'm only reporting from my experience, in case you were
wondering what you could improve:
People push branches to their trees and wait for the robot to test them.
And they wait and wait. But instead, such silly warnings come.
So it would be a lot better if you could expedite such pushed branches'
build tests first and then the rest.
And then if there are no branches, submitted patchsets on the ML.
If you're trying to figure out what base to use, you can put a doc
somewhere telling people how to specify the base for you and they will
start doing it, you will parse the 0th message for that info and use the
base.
And the long-standing feature request we have: a simple web page
somewhere which says how far is it with testing. So that people can go
and look at it and know whether to wait for test results before sending.
The web page doesn't have to be anything special - just a table of
branches being tested at the moment.
Anyway, I thought I should give you some suggestions if you were looking
for some. :-)
Thanks for the testing work - it is appreciated!
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-02-09 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 12:37 [tip:x86/cache 9/13] arch/x86/kernel/cpu/resctrl/rdtgroup.c:1456:6: warning: variable 'h' set but not used kernel test robot
2023-01-24 13:05 ` Borislav Petkov
2023-01-24 18:13 ` [PATCH] x86/resctrl: Fix a silly -Wunused-but-set-variable warning Borislav Petkov
2023-01-24 18:30 ` Reinette Chatre
2023-01-24 18:44 ` Moger, Babu
2023-02-09 3:06 ` [tip:x86/cache 9/13] arch/x86/kernel/cpu/resctrl/rdtgroup.c:1456:6: warning: variable 'h' set but not used Philip Li
2023-02-09 9:53 ` Borislav Petkov [this message]
2023-02-10 3:15 ` Philip Li
2023-02-10 21:49 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+TCq4k+0AhfjZkL@zn.tnic \
--to=bp@alien8.de \
--cc=babu.moger@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=philip.li@intel.com \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox