Re: [PATCHv5 04/13] zram: Introduce recompress sysfs knob

Nathan Chancellor
2022-11-10T15:18:20Z

On Thu, Nov 10, 2022 at 11:38:57PM +0900, Sergey Senozhatsky wrote:
> On (22/11/10 23:31), Sergey Senozhatsky wrote:
> > On (22/11/10 06:09), Nathan Chancellor wrote:
> > [..]
> > > drivers/block/zram/zram_drv.c:1894:10: note: initialize the variable 'err' to silence this warning
> > > int err;
> > > ^
> > > = 0
> > > 7 errors generated.
> > >
> > > Is the fix just to initialize err to 0 as it suggests or should there be
> > > a different fix?
> >
> > Yes, that's the correct fix. Thanks for catching this. We had "err = 0"
> > in v4 of this patch set, but it somehow didn't make it to v5.
>
> Nathan, I just sent a simple one-liner patch. If you don't mind,
> may we ask Andrew to take it as a fixup (folded) patch?

Yup, sounds like a plan to me, thanks for the quick response and fix!

Cheers,
Nathan