From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-usb@vger.kernel.org
Subject: Re: [usb:usb-testing 2/23] drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated fall-through between switch labels
Date: Tue, 29 Nov 2022 13:10:04 +0100 [thread overview]
Message-ID: <Y4X2nGH+LJDM6dDV@kroah.com> (raw)
In-Reply-To: <20221129101904.GM18924@pengutronix.de>
On Tue, Nov 29, 2022 at 11:19:04AM +0100, Michael Grzeschik wrote:
> On Tue, Nov 29, 2022 at 08:59:04AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Nov 29, 2022 at 08:57:19AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Nov 29, 2022 at 08:55:43AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Nov 29, 2022 at 07:22:43AM +0800, kernel test robot wrote:
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > > > > head: 465d4dd073f72a6348577ed0f7aa4aa00c9264bc
> > > > > commit: a6f523ee41bfe7ef71110d4ae556339d0520efdd [2/23] usb: gadget: uvc: add validate and fix function for uvc response
> > > >
> > > > Michael, I'll drop this commit from my tree now, please fix up and
> > > > resend.
> > >
> > > Nevermind, I fixed it up myself, it was trivial.
> >
> > And now ignore this, I've dropped it again based on Laurent's review.
> >
>
> Did you drop it because of the question why this is a good idea?
Yes.
> If so I will improve the commit message. IMHO it totally makes sense to
> have some sort of validation in the uvc gadget.
>
> The version v7 he commented on was not the one you took on the
> usb-testing tree.
Ok, submit a new one so that everyone can agree please.
thanks,
greg k-h
prev parent reply other threads:[~2022-11-29 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 23:22 [usb:usb-testing 2/23] drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated fall-through between switch labels kernel test robot
2022-11-29 7:55 ` Greg Kroah-Hartman
2022-11-29 7:57 ` Greg Kroah-Hartman
2022-11-29 7:59 ` Greg Kroah-Hartman
2022-11-29 10:19 ` Michael Grzeschik
2022-11-29 12:10 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4X2nGH+LJDM6dDV@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mgr@pengutronix.de \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox