From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id C39742583;
	Tue, 29 Nov 2022 12:10:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E97FBC433D7;
	Tue, 29 Nov 2022 12:10:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1669723807;
	bh=mtnawcMuSzHzZ2UbQGo6aEgto2AHflhvObJh3ex0GDM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=fwFjcrkJBs5NFqnXqn6st5NREIXm0i0OWjrMc0w1uQYOq/AzuksuttLVFPYfOq9RA
	 wRbuPXu4mCZD3iLu/nmcypMkwxoDOlHVUIi85GDqnxx9y8Uq3jZ30k5Fz3OF60DEoZ
	 ZGZXHu+kCLDRlYADxB6HpKbBa0JxIjK3YVBPv9cI=
Date: Tue, 29 Nov 2022 13:10:04 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: kernel test robot <lkp@intel.com>, llvm@lists.linux.dev,
	oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org
Subject: Re: [usb:usb-testing 2/23]
 drivers/usb/gadget/function/uvc_v4l2.c:266:3: warning: unannotated
 fall-through between switch labels
Message-ID: <Y4X2nGH+LJDM6dDV@kroah.com>
References: <202211290734.P9mHcjpl-lkp@intel.com>
 <Y4W6/0Ql3dI+ePXF@kroah.com>
 <Y4W7Xw6OA9GLzXmH@kroah.com>
 <Y4W7yKbiKzK4yKoV@kroah.com>
 <20221129101904.GM18924@pengutronix.de>
Precedence: bulk
X-Mailing-List: llvm@lists.linux.dev
List-Id: <llvm.lists.linux.dev>
List-Subscribe: <mailto:llvm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:llvm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129101904.GM18924@pengutronix.de>

On Tue, Nov 29, 2022 at 11:19:04AM +0100, Michael Grzeschik wrote:
> On Tue, Nov 29, 2022 at 08:59:04AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Nov 29, 2022 at 08:57:19AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Nov 29, 2022 at 08:55:43AM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Nov 29, 2022 at 07:22:43AM +0800, kernel test robot wrote:
> > > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > > > > head:   465d4dd073f72a6348577ed0f7aa4aa00c9264bc
> > > > > commit: a6f523ee41bfe7ef71110d4ae556339d0520efdd [2/23] usb: gadget: uvc: add validate and fix function for uvc response
> > > >
> > > > Michael, I'll drop this commit from my tree now, please fix up and
> > > > resend.
> > > 
> > > Nevermind, I fixed it up myself, it was trivial.
> > 
> > And now ignore this, I've dropped it again based on Laurent's review.
> > 
> 
> Did you drop it because of the question why this is a good idea?

Yes.

> If so I will improve the commit message. IMHO it totally makes sense to
> have some sort of validation in the uvc gadget.
> 
> The version v7 he commented on was not the one you took on the
> usb-testing tree.

Ok, submit a new one so that everyone can agree please.

thanks,

greg k-h