Re: [PATCH 6.0 000/289] 6.0.11-rc1 review

Re: [PATCH 6.0 000/289] 6.0.11-rc1 review

[Naresh Kamboju]

On Thu, 1 Dec 2022 at 00:13, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.0.11 release.
> There are 289 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 02 Dec 2022 18:05:05 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.0.11-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.0.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro's test farm.
Regressions found on x86_64:

    - build-clang-15-allmodconfig-x86_64
    - build-clang-nightly-allmodconfig-x86_64

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

    bpf: Convert BPF_DISPATCHER to use static_call() (not ftrace)
    [ Upstream commit c86df29d11dfba27c0a1f5039cd6fe387fbf4239 ]

Causing the following build warnings / errors with clang-15 allmodconfig
on x86_64,

Build error:
make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/build LLVM=1 LLVM_IAS=1
ARCH=x86_64 SRCARCH=x86 CROSS_COMPILE=x86_64-linux-gnu-
'HOSTCC=sccache clang' 'CC=sccache clang'
kernel/bpf/dispatcher.c:126:33: error: pointer type mismatch ('void *'
and 'unsigned int (*)(const void *, const struct bpf_insn *,
bpf_func_t)' (aka 'unsigned int (*)(const void *, const struct
bpf_insn *, unsigned int (*)(const void *, const struct bpf_insn
*))')) [-Werror,-Wpointer-type-mismatch]
        __BPF_DISPATCHER_UPDATE(d, new ?: &bpf_dispatcher_nop_func);
                                   ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:938:54: note: expanded from macro '__BPF_DISPATCHER_UPDATE'
        __static_call_update((_d)->sc_key, (_d)->sc_tramp, (_new))
                                                            ^~~~
1 error generated.

Build logs:
  - https://builds.tuxbuild.com/2IHYTj6JN108YShWQ8K8Fd0HyVW/

--
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 6.0 000/289] 6.0.11-rc1 review

[Nathan Chancellor]

On Thu, Dec 01, 2022 at 11:44:53AM +0530, Naresh Kamboju wrote:
> On Thu, 1 Dec 2022 at 00:13, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 6.0.11 release.
> > There are 289 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 02 Dec 2022 18:05:05 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.0.11-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.0.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> Results from Linaro's test farm.
> Regressions found on x86_64:
> 
>     - build-clang-15-allmodconfig-x86_64
>     - build-clang-nightly-allmodconfig-x86_64
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
>     bpf: Convert BPF_DISPATCHER to use static_call() (not ftrace)
>     [ Upstream commit c86df29d11dfba27c0a1f5039cd6fe387fbf4239 ]
> 
> Causing the following build warnings / errors with clang-15 allmodconfig
> on x86_64,
> 
> Build error:
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/build LLVM=1 LLVM_IAS=1
> ARCH=x86_64 SRCARCH=x86 CROSS_COMPILE=x86_64-linux-gnu-
> 'HOSTCC=sccache clang' 'CC=sccache clang'
> kernel/bpf/dispatcher.c:126:33: error: pointer type mismatch ('void *'
> and 'unsigned int (*)(const void *, const struct bpf_insn *,
> bpf_func_t)' (aka 'unsigned int (*)(const void *, const struct
> bpf_insn *, unsigned int (*)(const void *, const struct bpf_insn
> *))')) [-Werror,-Wpointer-type-mismatch]
>         __BPF_DISPATCHER_UPDATE(d, new ?: &bpf_dispatcher_nop_func);
>                                    ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/bpf.h:938:54: note: expanded from macro '__BPF_DISPATCHER_UPDATE'
>         __static_call_update((_d)->sc_key, (_d)->sc_tramp, (_new))
>                                                             ^~~~
> 1 error generated.

Thanks for the report! This is fixed with upstream commit a679120edfcf
("bpf: Add explicit cast to 'void *' for __BPF_DISPATCHER_UPDATE()"),
which was marked as a fix for c86df29d11df.

Cheers,
Nathan

Re: [PATCH 6.0 000/289] 6.0.11-rc1 review

[Greg Kroah-Hartman]

On Wed, Nov 30, 2022 at 11:57:24PM -0700, Nathan Chancellor wrote:
> On Thu, Dec 01, 2022 at 11:44:53AM +0530, Naresh Kamboju wrote:
> > On Thu, 1 Dec 2022 at 00:13, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 6.0.11 release.
> > > There are 289 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Fri, 02 Dec 2022 18:05:05 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.0.11-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.0.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > 
> > Results from Linaro's test farm.
> > Regressions found on x86_64:
> > 
> >     - build-clang-15-allmodconfig-x86_64
> >     - build-clang-nightly-allmodconfig-x86_64
> > 
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > 
> >     bpf: Convert BPF_DISPATCHER to use static_call() (not ftrace)
> >     [ Upstream commit c86df29d11dfba27c0a1f5039cd6fe387fbf4239 ]
> > 
> > Causing the following build warnings / errors with clang-15 allmodconfig
> > on x86_64,
> > 
> > Build error:
> > make --silent --keep-going --jobs=8
> > O=/home/tuxbuild/.cache/tuxmake/builds/1/build LLVM=1 LLVM_IAS=1
> > ARCH=x86_64 SRCARCH=x86 CROSS_COMPILE=x86_64-linux-gnu-
> > 'HOSTCC=sccache clang' 'CC=sccache clang'
> > kernel/bpf/dispatcher.c:126:33: error: pointer type mismatch ('void *'
> > and 'unsigned int (*)(const void *, const struct bpf_insn *,
> > bpf_func_t)' (aka 'unsigned int (*)(const void *, const struct
> > bpf_insn *, unsigned int (*)(const void *, const struct bpf_insn
> > *))')) [-Werror,-Wpointer-type-mismatch]
> >         __BPF_DISPATCHER_UPDATE(d, new ?: &bpf_dispatcher_nop_func);
> >                                    ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
> > include/linux/bpf.h:938:54: note: expanded from macro '__BPF_DISPATCHER_UPDATE'
> >         __static_call_update((_d)->sc_key, (_d)->sc_tramp, (_new))
> >                                                             ^~~~
> > 1 error generated.
> 
> Thanks for the report! This is fixed with upstream commit a679120edfcf
> ("bpf: Add explicit cast to 'void *' for __BPF_DISPATCHER_UPDATE()"),
> which was marked as a fix for c86df29d11df.

Now queued up.  I forgot to run my "do we need fixes for the fixes"
script on the queues, sorry about that.

greg k-h