From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 812A08F44 for ; Thu, 12 Jan 2023 20:56:25 +0000 (UTC) Received: from leknes.fjasle.eu ([46.142.98.230]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N1gWU-1oaJdR0OV6-011wFY; Thu, 12 Jan 2023 21:40:49 +0100 Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 970333C1B9; Thu, 12 Jan 2023 21:40:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1673556047; bh=5lJd4UqMcvR4THZLV0UxZhYJKneRHMCk8SGHPphfMuY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u62/aBNH/kUtLAgLaEyfy71mGH3Z38lzADxJExxY0mylyi94Pzd+R+rYBojYtKc3D k5GNYFkKoUEQ0EXsT9xz0fRg2sjfU2f2Qx8i+SWmtm9qM8S8JVDRYUtsmk6SMK78W4 tc625dJ4BO69sU85ecBCfYzdgR7vnwW7dWBiwJ38= Date: Thu, 12 Jan 2023 21:40:45 +0100 From: Nicolas Schier To: Ian Rogers Cc: Josh Poimboeuf , Peter Zijlstra , Nathan Chancellor , Nick Desaulniers , Tom Rix , Masahiro Yamada , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Stephane Eranian , Andrii Nakryiko , Jiri Olsa , Arnaldo Carvalho de Melo , Namhyung Kim Subject: Re: [PATCH v3 3/3] objtool: Alter how HOSTCC is forced Message-ID: References: <20230105090155.357604-1-irogers@google.com> <20230105090155.357604-4-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hgmatHOWyR+UeKy1" Content-Disposition: inline In-Reply-To: <20230105090155.357604-4-irogers@google.com> X-Provags-ID: V03:K1:wOccXVEvjaXr8f52saPXX3/F9hw7Zj2gIRO88AwcRt3v9E8Szov 7PMZ7F3P/IpLm1K/UHVI5Y+lKSgpgl6gkdZLnu1GmxheTeF8nhvd3dt2O3TtijVRxirGPRd J/i6wMdPweXePI9DnUwWSI/Sh39I4jJwfQ6U8Mzw/jbEc39AskQ2Jspoyi+fE2uEZPETSYD 4LgXaa8pRu9Pwomh8J8QQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:78iPcWj/3OI=;ypqrr4PiVC/+/feegckAqBTk/Q/ RXS0FaiTSvX7ny32ur9SaFPxekAPIu2rrAy1gHr1JD9VPhop0sMoeS38dNWmZBJzetV51PwaQ /hwjzATbyegcdfe6g2P3xNVBMJN5efD+JBDXPQQjhY1pjj4p6y/Tecr2ubu5mK30A9E05yoT4 qpPJabpMEAmaaIDQpFlvwfs/zV8bAGhzd5qVe5tomSyIFa4ODYgYRhSmGCqM3JcmRB73Eq4Co 8igPE3YRDl1WYaVczejP33OMcUJZnPVgQcrvB2fT5QPm6p/CWz1/camHTlLaoct8WlDfKIAsk 3wbN/AQ2Fmds/2n+exgP+lqahBX2zkZVfRAqoInjljoZL5fGLEpKtHwikOSKN01f40dvwO5N7 vWJVAWET++U4+2ozMARDHc14Ko2oPpINO2G1YsJBa1Eet766o7St6toFPXDjKqLZfF+uwLKKI DFUmFjof+2dLqSHrX7sdCrtZhgpTmcs7TjIS8Cv24M4to9qNBh5V4xHUsOoZwWowyw8qEKzdo NUKnO+rXKWVsAA1ElJPL5MwlRgeVRhuNkI/6TodCBelS7pnO2zdEvBwyH97mLyLvx8lSCxTLJ KUokeOMwW3am29Hn8JHSJFe3j+GZS3sTWniv1HXPaJtw94hWzpEvHhR6z90s/XtYBgnrdZyZr ehERiPMLwxDo9xcvG302R2DRiJv3t3BEQNNqqCVBaA== --hgmatHOWyR+UeKy1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 05, 2023 at 01:01:55AM -0800 Ian Rogers wrote: > HOSTCC is always wanted when building objtool. Setting CC to HOSTCC > happens after tools/scripts/Makefile.include is included, meaning > flags are set assuming say CC is gcc, but then it can be later set to > HOSTCC which may be clang. tools/scripts/Makefile.include is needed > for host set up and common macros in objtool's Makefile. Rather than > override CC to HOSTCC, just pass CC as HOSTCC to Makefile.build, the > libsubcmd builds and the linkage step. This means the Makefiles don't > see things like CC changing and tool flag determination, and similar, > work properly. To avoid mixing CFLAGS from different compilers just > the objtool CFLAGS are determined with the exception of > EXTRA_WARNINGS. HOSTCFLAGS is added to these so that command line > flags can add to the CFLAGS. >=20 > Signed-off-by: Ian Rogers > --- > tools/objtool/Makefile | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) >=20 Reviewed-by: Nicolas Schier --hgmatHOWyR+UeKy1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmPAcEwACgkQB1IKcBYm Eml90g//Qq0msUrlto/hLtRrjPmQVn/zodLU2GjxYShMzh26FxskQin/pu6eaH3a qvRk0sQXEireXfPSJKkjlgfeTc8qocUNx5ueOyl3B/ZPOEYfvn8dC+wGFB0yseOO SGiKChCk7mTpDvlieElc8dNwZsm7j1BWRwxMiXyviyR8K7JHndbAh2RvDu0ek4yM yFd3UOMAOX4wvz8m4Zwl2sqJXqGOSYkcvJWFs1PxpYJRpfjIrzbVVFd9LIkG0iKa jQQX0uHUxXzvSji2Ewz/iAFYvq5FKS25xAopL8Ms0p91h8jRoUYzg4qWTVezOM3Q QPXs5Af7EUiR8QwlvMCda3G0yaYC7g/rAX1zjQL/zndHbrnEj0RPr4CGa5ymQWsZ Hc+/ijjNQYKzu/h3y8hqtE1C14YwZzI6IiCHq9hmnUoD2pKah3CjRfCfR7fclJz9 iQP/39VRBlCMQnIF7vuf1HdDzw6wRxMn0CXRLVq4AlnMXP2nPwCyphNsOnVGpelG ruExqeR44uNbB7kUdri0sTIUU95KyS0JXnOu3VhR8GmJ5NMjWgDxEBeUzNf8VbQE 88rezTHCsYcCC2tE9q1qTxKc5DL+YcxZzLCDaqhSOnlVjrmgKJTIggXh72ca/LPm 2xbd2z9MTA3dcPkIASh6ffcTCvbfRbBs51eCV46x4l3/3i/GAic= =egz2 -----END PGP SIGNATURE----- --hgmatHOWyR+UeKy1--