From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] iio: frequency: adrf6780: Fix adrf6780_spi_{read,write}()
Date: Sun, 24 Oct 2021 13:14:51 +0200 [thread overview]
Message-ID: <YXVAK9ffYSpY1m/N@kroah.com> (raw)
In-Reply-To: <20211023164333.36b2ea2c@jic23-huawei>
On Sat, Oct 23, 2021 at 04:43:33PM +0100, Jonathan Cameron wrote:
> On Fri, 22 Oct 2021 12:56:56 -0700
> Nathan Chancellor <nathan@kernel.org> wrote:
>
> > Clang warns:
> >
> > drivers/iio/frequency/adrf6780.c:117:1: error: all paths through this
> > function will call itself [-Werror,-Winfinite-recursion]
> > {
> > ^
> > drivers/iio/frequency/adrf6780.c:138:1: error: all paths through this
> > function will call itself [-Werror,-Winfinite-recursion]
> > {
> > ^
> > 2 errors generated.
> >
> > The underscore variants should be used here.
> >
> > Fixes: 63aaf6d06d87 ("iio: frequency: adrf6780: add support for ADRF6780")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1490
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Thanks Nathan, (bit embarrassed I missed this in review :(
> As you probably guessed I didn't run an llvm test this time - guess I should
> start doing that on a regular basis.
>
> We obviously have plenty of time to get this fix in place but
> seeing as I just sent a pull request for the driver a few hours before this
> patch:
>
> Greg, would you mind picking this one up directly on top of
> [PULL] 2nd set of IIO new device support, features, cleanup for 5.16
> if you take that pull request?
>
> Message ID for this one is:
>
> 20211022195656.1513147-1-nathan@kernel.org
>
> No problem if you'd rather I just queue this fix up for post merge
> window.
>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Picked it up now, thanks!
greg k-h
prev parent reply other threads:[~2021-10-24 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 19:56 [PATCH] iio: frequency: adrf6780: Fix adrf6780_spi_{read,write}() Nathan Chancellor
2021-10-23 15:43 ` Jonathan Cameron
2021-10-24 11:14 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXVAK9ffYSpY1m/N@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox