Re: [PATCH 18/20] media: mtk-mdp: address a clang warning

Arnd Bergmann
2021-11-24T19:22:08Z

On Wed, Nov 24, 2021 at 8:13 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> The typecasts at the dvb-core generate clang warnings when W=1
> is enabled.
>
> Such warning is harmless, but it causes the build to break with
> CONFIG_WERROR and W=1 with clang, so do the cast on a way that
> it won't produce warnings anymore.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

>
> - comp_type = (enum mtk_mdp_comp_type)of_id->data;
> + comp_type = (long)of_id->data;

I would generally use (uintptr_t) for this purpose, but the effect is the same.

Arnd