Re: [PATCH 20/20] media: mxl5005s: drop some dead code

Nathan Chancellor
2021-11-26T20:30:23Z

On Wed, Nov 24, 2021 at 08:13:23PM +0100, Mauro Carvalho Chehab wrote:
> As reported by clang (with W=1), the ctrlVal var is never used.
>
> Yet, there are even some loops to estimate it. As this is dead
> code, remove it. If ever needed, someone could revert this
> patch.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/
>
> drivers/media/tuners/mxl5005s.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/media/tuners/mxl5005s.c b/drivers/media/tuners/mxl5005s.c
> index f6e82a8e7d37..ab4c43df9d18 100644
> --- a/drivers/media/tuners/mxl5005s.c
> +++ b/drivers/media/tuners/mxl5005s.c
> @@ -3414,9 +3414,8 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
> u32 value, u16 controlGroup)
> {
> struct mxl5005s_state *state = fe->tuner_priv;
> - u16 i, j, k;
> + u16 i, j;
> u32 highLimit;
> - u32 ctrlVal;
>
> if (controlGroup == 1) /* Initial Control */ {
>
> @@ -3432,9 +3431,6 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
> (u8)(state->Init_Ctrl[i].bit[j]),
> (u8)((value>>j) & 0x01));
> }
> - ctrlVal = 0;
> - for (k = 0; k < state->Init_Ctrl[i].size; k++)
> - ctrlVal += state->Init_Ctrl[i].val[k] * (1 << k);
> } else
> return -1;
> }
> @@ -3454,9 +3450,6 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
> (u8)(state->CH_Ctrl[i].bit[j]),
> (u8)((value>>j) & 0x01));
> }
> - ctrlVal = 0;
> - for (k = 0; k < state->CH_Ctrl[i].size; k++)
> - ctrlVal += state->CH_Ctrl[i].val[k] * (1 << k);
> } else
> return -1;
> }
> @@ -3477,11 +3470,6 @@ static u16 MXL_ControlWrite_Group(struct dvb_frontend *fe, u16 controlNum,
> (u8)(state->MXL_Ctrl[i].bit[j]),
> (u8)((value>>j) & 0x01));
> }
> - ctrlVal = 0;
> - for (k = 0; k < state->MXL_Ctrl[i].size; k++)
> - ctrlVal += state->
> - MXL_Ctrl[i].val[k] *
> - (1 << k);
> } else
> return -1;
> }
> --
> 2.33.1
>
>