From: Nathan Chancellor <nathan@kernel.org>
To: Samuel Zeter <samuelzeter@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 0/2] *** Fix reformat_objdump.awk ***
Date: Thu, 6 Jan 2022 12:02:25 -0700 [thread overview]
Message-ID: <Ydc8wUjX4hnHg7ZE@archlinux-ax161> (raw)
In-Reply-To: <20220106023606.283953-1-samuelzeter@gmail.com>
On Thu, Jan 06, 2022 at 01:36:03PM +1100, Samuel Zeter wrote:
> These are two small patches which originally dealt with
> the problem found at:
>
> https://github.com/ClangBuiltLinux/linux/issues/1364
>
> The original steps to reproduce were:
> $ make -skj"$(nproc)" LLVM=1 LLVM_IAS=1 defconfig
> $ scripts/config -e X86_DECODER_SELFTEST
> $ make -skj"$(nproc)" LLVM=1 LLVM_IAS=1 olddefconfig bzImage
>
> Which resulted in the error:
> arch/x86/tools/insn_decoder_test: warning: objdump says 0 bytes, but
> insn_get_length() says 2
>
> Upon inspection it turned out llvm-objdump was formatting its
> output differently, which caused objdump_reformat.awk to incorrectly
> output its values.
>
> After fixing that bug, a second one was seen where the instruction
> "wait" was incorrectly matched with "fwait", which again caused
> insn_decoder_test to fail.
Thanks a lot for sending these fixes!
I can confirm with this series and the removal of chkobjdump.awk [1] on
top of v5.16-rc8, the insn_decoder_test now passes with LLVM 11 through
14.
Tested-by: Nathan Chancellor <nathan@kernel.org>
For the future, I recommend putting the maintainers in the "To" field,
rather than "Cc", to ensure they actually see it. Additionally, I see
some small nits in the commit message that the tip maintainers might
comment on, see
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog
for some more info.
Masami Hiramatsu originally wrote this file and has a few fixes to it
since, adding him now for review. The original thread is available at:
https://lore.kernel.org/r/20220106023606.283953-1-samuelzeter@gmail.com/
[1]: https://git.kernel.org/nathan/c/2f137c324b21f1c21b8830d8896cb9957009f969
Cheers,
Nathan
next prev parent reply other threads:[~2022-01-06 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 2:36 [PATCH 0/2] *** Fix reformat_objdump.awk *** Samuel Zeter
2022-01-06 2:36 ` [PATCH 1/2] arch/x86/tools/objdump_reformat.awk: Ensure regex matches fwait Samuel Zeter
2022-01-06 2:36 ` [PATCH 2/2] arch/x86/tools/objdump_reformat.awk: Allow for spaces Samuel Zeter
2022-01-06 19:02 ` Nathan Chancellor [this message]
2022-01-06 23:23 ` [PATCH 0/2] *** Fix reformat_objdump.awk *** Samuel Zeter
2022-01-07 0:16 ` Nathan Chancellor
2022-03-04 3:16 ` [PATCH v2 " Sam Zeter
2022-03-04 3:16 ` [PATCH v2 1/2] arch/x86/tools/objdump_reformat.awk: Ensure regex matches fwait Sam Zeter
2022-03-04 3:16 ` [PATCH v2 2/2] arch/x86/tools/objdump_reformat.awk: Allow for spaces Sam Zeter
2022-03-04 17:20 ` [PATCH v2 0/2] *** Fix reformat_objdump.awk *** Nathan Chancellor
2022-01-07 11:52 ` [PATCH " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydc8wUjX4hnHg7ZE@archlinux-ax161 \
--to=nathan@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=samuelzeter@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).