From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CCCE38DF for ; Thu, 17 Feb 2022 00:37:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F37CC004E1; Thu, 17 Feb 2022 00:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645058239; bh=Jse37Gv/FnjBWQ3ysuSP5HtMYEFNEpKn11Uwq/2SITw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RQDBnsc2JFAmf6I3DvnJry/b1qFlhqSRrrFtSBB3uQgkYn8rLSjH4TmDwEgspboEp ZYudBDEFFc/d0gunx8OYqyarmMB1WqTd/UF43t/syGPIMCThVcK/ZLk8fULXkRP08p 3XHnOniUr6envfAoU3S/pPlak535axWtN5PvsXi4VSPMKZO+Z6kg2PCetkkmQdQu0A pfe/5pcoFCmw9oyifU6HBc1wJ3N7LiF+6FpkC49SzJZT3h71FCKc54zM+NQpOqELCV uozqEDiyNmqF6/Shv33feDH8lF1+c0386LCaq5iOiwBEakHU6NYUMGUnw772yjAyRJ QMe4TbQBOfXHw== Date: Wed, 16 Feb 2022 17:37:13 -0700 From: Nathan Chancellor To: Kees Cook Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , Masahiro Yamada , Nick Desaulniers , David Gow , linux-um@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] um: Allow builds with Clang Message-ID: References: <20220217002843.2312603-1-keescook@chromium.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220217002843.2312603-1-keescook@chromium.org> On Wed, Feb 16, 2022 at 04:28:43PM -0800, Kees Cook wrote: > Add x86-64 target for Clang+um and update user-offsets.c to use > Clang-friendly assembler, similar to the fix from commit cf0c3e68aa81 Clang-friendly assembly? > ("kbuild: fix asm-offset generation to work with clang"). > > This lets me run KUnit tests with Clang: > > $ ./tools/testing/kunit/kunit.py config --make_options LLVM=1 > ... > $ ./tools/testing/kunit/kunit.py run --make_options LLVM=1 > ... > > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Masahiro Yamada > Cc: Nick Desaulniers > Cc: Nathan Chancellor > Cc: David Gow > Cc: linux-um@lists.infradead.org > Cc: linux-kbuild@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Cc: kunit-dev@googlegroups.com > Cc: llvm@lists.linux.dev > Signed-off-by: Kees Cook I am not super familiar with UML but this seems reasonable. Reviewed-by: Nathan Chancellor One small nit below if you have to send a v2, not sure it is worth it otherwise. > --- > arch/x86/um/user-offsets.c | 4 ++-- > scripts/Makefile.clang | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/um/user-offsets.c b/arch/x86/um/user-offsets.c > index bae61554abcc..d9071827b515 100644 > --- a/arch/x86/um/user-offsets.c > +++ b/arch/x86/um/user-offsets.c > @@ -10,10 +10,10 @@ > #include > > #define DEFINE(sym, val) \ > - asm volatile("\n->" #sym " %0 " #val : : "i" (val)) > + asm volatile("\n.ascii \"->" #sym " %0 " #val "\"": : "i" (val)) > > #define DEFINE_LONGS(sym, val) \ > - asm volatile("\n->" #sym " %0 " #val : : "i" (val/sizeof(unsigned long))) > + asm volatile("\n.ascii \"->" #sym " %0 " #val "\"": : "i" (val/sizeof(unsigned long))) > > void foo(void) > { > diff --git a/scripts/Makefile.clang b/scripts/Makefile.clang > index 51fc23e2e9e5..857b23de51c6 100644 > --- a/scripts/Makefile.clang > +++ b/scripts/Makefile.clang > @@ -10,6 +10,7 @@ CLANG_TARGET_FLAGS_powerpc := powerpc64le-linux-gnu > CLANG_TARGET_FLAGS_riscv := riscv64-linux-gnu > CLANG_TARGET_FLAGS_s390 := s390x-linux-gnu > CLANG_TARGET_FLAGS_x86 := x86_64-linux-gnu > +CLANG_TARGET_FLAGS_um := x86_64-linux-gnu It might be nice to keep this in alphabetical order. > CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(SRCARCH)) > > ifeq ($(CROSS_COMPILE),) > -- > 2.30.2 > >