From: Nathan Chancellor <nathan@kernel.org>
To: Fangrui Song <maskray@google.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] riscv module: remove (NOLOAD)
Date: Sat, 19 Feb 2022 09:45:10 -0700 [thread overview]
Message-ID: <YhEelqnPDr1u4uTD@dev-arch.archlinux-ax161> (raw)
In-Reply-To: <20220218082611.396353-1-maskray@google.com>
On Fri, Feb 18, 2022 at 12:26:11AM -0800, Fangrui Song wrote:
> On ELF, (NOLOAD) sets the section type to SHT_NOBITS[1]. It is conceptually
> inappropriate for .plt, .got, and .got.plt sections which are always
> SHT_PROGBITS.
>
> In GNU ld, if PLT entries are needed, .plt will be SHT_PROGBITS anyway
> and (NOLOAD) will be essentially ignored. In ld.lld, since
> https://reviews.llvm.org/D118840 ("[ELF] Support (TYPE=<value>) to
> customize the output section type"), ld.lld will report a `section type
> mismatch` error. Just remove (NOLOAD) to fix the error.
>
> [1] https://lld.llvm.org/ELF/linker_script.html As of today, "The
> section should be marked as not loadable" on
> https://sourceware.org/binutils/docs/ld/Output-Section-Type.html is
> outdated for ELF.
Thank you for the patch! As mentioned on the arm64 patch, this needs
your Signed-off-by tag. With that provided:
Cc: stable@vger.kernel.org
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
This needs to go to stable so that older trees with a newer toolchain do
not warn.
> ---
> arch/riscv/include/asm/module.lds.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/include/asm/module.lds.h b/arch/riscv/include/asm/module.lds.h
> index 4254ff2ff049..1075beae1ac6 100644
> --- a/arch/riscv/include/asm/module.lds.h
> +++ b/arch/riscv/include/asm/module.lds.h
> @@ -2,8 +2,8 @@
> /* Copyright (C) 2017 Andes Technology Corporation */
> #ifdef CONFIG_MODULE_SECTIONS
> SECTIONS {
> - .plt (NOLOAD) : { BYTE(0) }
> - .got (NOLOAD) : { BYTE(0) }
> - .got.plt (NOLOAD) : { BYTE(0) }
> + .plt : { BYTE(0) }
> + .got : { BYTE(0) }
> + .got.plt : { BYTE(0) }
> }
> #endif
> --
> 2.35.1.265.g69c8d7142f-goog
>
>
next prev parent reply other threads:[~2022-02-19 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 8:26 [PATCH] riscv module: remove (NOLOAD) Fangrui Song
2022-02-19 16:45 ` Nathan Chancellor [this message]
2022-03-18 23:18 ` Palmer Dabbelt
2022-03-22 1:26 ` [PATCH v2] " Fangrui Song
2022-03-22 1:49 ` Nathan Chancellor
2022-03-30 0:21 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhEelqnPDr1u4uTD@dev-arch.archlinux-ax161 \
--to=nathan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=maskray@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox