Re: [RFC PATCH 03/13] usb: remove the usage of the list iterator after the loop

Re: [RFC PATCH 03/13] usb: remove the usage of the list iterator after the loop

[Nathan Chancellor]

On Wed, Feb 23, 2022 at 01:53:39PM -0800, Linus Torvalds wrote:
> On Wed, Feb 23, 2022 at 1:46 PM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > > Ok, so we should be able to basically convert '--std=gnu89' into
> > > '--std=gnu11 -Wno-shift-negative-value' with no expected change of
> > > behavior.
> >
> > Yes, I think that is correct.
> 
> Ok, somebody please remind me, and let's just try this early in the
> 5.18 merge window.
> 
> Because at least for me, doing
> 
> -                  -std=gnu89
> +                  -std=gnu11 -Wno-shift-negative-value
> 
> for KBUILD_CFLAGS works fine both in my gcc and clang builds. But
> that's obviously just one version of each.

I ran that diff through my set of clang builds on
v5.17-rc5-21-g23d04328444a and only found one issue:

https://github.com/ClangBuiltLinux/linux/issues/1603

I think that should be fixed on the clang side. Once it is, I think we
could just disable that warning in those translation units for older
versions of clang to keep the status quo.

Cheers,
Nathan