From: Baoquan He <bhe@redhat.com>
To: Michal Orzel <michalorzel.eng@gmail.com>, akpm@linux-foundation.org
Cc: Eric Biederman <ebiederm@xmission.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] kexec: Remove redundant assignments
Date: Thu, 31 Mar 2022 19:22:43 +0800 [thread overview]
Message-ID: <YkWPA0XDEMq1NVcr@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220326180948.192154-1-michalorzel.eng@gmail.com>
On 03/26/22 at 07:09pm, Michal Orzel wrote:
> Get rid of redundant assignments which end up in values not being
> read either because they are overwritten or the function ends.
>
> Reported by clang-tidy [deadcode.DeadStores]
>
> Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
> ---
> kernel/kexec_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 68480f731192..d08904a27362 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -768,7 +768,6 @@ static struct page *kimage_alloc_page(struct kimage *image,
> kimage_free_pages(old_page);
> continue;
> }
> - addr = old_addr;
> page = old_page;
> break;
> }
> @@ -788,7 +787,6 @@ static int kimage_load_normal_segment(struct kimage *image,
> unsigned char __user *buf = NULL;
> unsigned char *kbuf = NULL;
>
> - result = 0;
> if (image->file_mode)
> kbuf = segment->kbuf;
> else
LGTM, thx
Acked-by: Baoquan He <bhe@redhat.com>
prev parent reply other threads:[~2022-03-31 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 18:09 [PATCH] kexec: Remove redundant assignments Michal Orzel
2022-03-31 11:22 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkWPA0XDEMq1NVcr@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michalorzel.eng@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox