From: Christoph Hellwig <hch@infradead.org>
To: Tom Rix <trix@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
tim@cyberelk.net, axboe@kernel.dk, jejb@linux.ibm.com,
martin.petersen@oracle.com, nathan@kernel.org,
ndesaulniers@google.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] security: do not leak information in ioctl
Date: Mon, 11 Apr 2022 22:25:38 -0700 [thread overview]
Message-ID: <YlUNUgTfej6VpkWS@infradead.org> (raw)
In-Reply-To: <eec2efee-1153-8d8e-77c2-96156733a0c6@redhat.com>
On Mon, Apr 11, 2022 at 09:31:20AM -0700, Tom Rix wrote:
> The failure can happen in the transfer loop, so some of the data will not be
> zero.
>
> And checking status should be done.
>
> zero-ing is because i am paranoid.
Maybe I'm just lost because of all the reformating. Please do a first
patch that split the CDROMREADTOCHDR and CDROMREADTOCENTRY into one
helper each and the just do the minimal fix on top so that it is
reviewable.
prev parent reply other threads:[~2022-04-12 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 14:51 [PATCH] security: do not leak information in ioctl Tom Rix
2022-04-11 15:07 ` Christoph Hellwig
2022-04-11 16:31 ` Tom Rix
2022-04-12 5:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlUNUgTfej6VpkWS@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tim@cyberelk.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).