From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E7B362 for ; Wed, 1 Jun 2022 07:27:46 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id y189so1167120pfy.10 for ; Wed, 01 Jun 2022 00:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eMeA/fqvYZU6vrSiCnNJA0sstC2+T/rmbcmFof3BR34=; b=Ve/MDQjVQ36HEHc3RKBr36SX9I68T1b4706XRvOHxHRgDsEzn3JOnjpOjtHXaFBlaE 5sKBR5xf0pwoFavEKOjpPGC+XjnBihHNbZG+Shi+XCMgIzx6OXcZAAqI9y/pFOAv6OJk TYwI4uyqOG/3HWq0jJQ3LeYVHTfwsp/ylK+2Fvn9+AQTOFCCVboUB2IldBbynyw5F+68 1Lkz3GjBIqDCp2v04ZbG9Eh5biTPgCosHS2Kv3LvfXxCabp2AxUB60JM3j6HTz4UhJpd B9Tq8YCUVg0SaKQI9UeErLNPGiL7bjX8DaO9Yp5sDidUQ+RsNOytfGbCqOD90Zi8gCk+ /ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eMeA/fqvYZU6vrSiCnNJA0sstC2+T/rmbcmFof3BR34=; b=rNhq5SO1cE3/JR8DmVMVHfz7wLwC82QGHb7v2Xx+4M7iLnokAWnaTA+KhT1W4h/VoR XYZE/oycb3RO8QvCNO09XcqKBIMdnqH7QVpTp/k4nSJnPHdRSlstTzPRUEEypACLpJNh gAXYV3hdv8DTkp4tgCB8DwYWroxw6xPDI6hRPujTgIKI19vqR86TELnkPswNP78P/eLF yeZEAlxD/I+tcOKNRQymx5iP85todMq8iFzIyPnmSI4TSwXpuRpRrWG6EFSUXWTv5Afc wtjgQNCxjWfAaxsUVK8uj/1rYT7r9liS2yKNwOqRynm0tZRLX4Hw1GOV2JszN+ZZDgE1 qrGw== X-Gm-Message-State: AOAM532PD3bWCJ2C2NuH2IGrVHwpIT6i5bMo7JxFb7EmiYmpCl63z8wJ EtcxSnBo4Fxw0n47b2V/gG0= X-Google-Smtp-Source: ABdhPJzncNVm9JEdvzWZ/WJX8rZD6Uc3eyRjjE+e9aLdBHmlkh2N+ra6ix7Phl7ZYouz3tV5tJAaCQ== X-Received: by 2002:a05:6a00:1d8e:b0:518:87e7:db00 with SMTP id z14-20020a056a001d8e00b0051887e7db00mr52648703pfw.84.1654068465543; Wed, 01 Jun 2022 00:27:45 -0700 (PDT) Received: from localhost (subs02-180-214-232-26.three.co.id. [180.214.232.26]) by smtp.gmail.com with ESMTPSA id gn1-20020a17090ac78100b001df82551cf2sm650434pjb.44.2022.06.01.00.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 00:27:44 -0700 (PDT) Date: Wed, 1 Jun 2022 14:27:42 +0700 From: Bagas Sanjaya To: Randy Dunlap Cc: linux-doc@vger.kernel.org, kernel test robot , Nikolai Kondrashov , Jiri Kosina , Benjamin Tissoires , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , llvm@lists.linux.dev, stable@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] HID: uclogic: properly format kernel-doc comment for hid_dbg() wrappers Message-ID: References: <20220531092817.13894-1-bagasdotme@gmail.com> <3995c3d8-395a-bd39-eebc-370bd1fca09c@infradead.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3995c3d8-395a-bd39-eebc-370bd1fca09c@infradead.org> > One note (nit) below: > > > drivers/hid/hid-uclogic-params.c | 24 ++++++++++++++---------- > > 1 file changed, 14 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c > > index db838f16282d64..647bbd3e000e2f 100644 > > --- a/drivers/hid/hid-uclogic-params.c > > +++ b/drivers/hid/hid-uclogic-params.c > > @@ -23,11 +23,11 @@ > > /** > > * uclogic_params_pen_inrange_to_str() - Convert a pen in-range reporting type > > * to a string. > > - * > > * @inrange: The in-range reporting type to convert. > > * > > - * Returns: > > - * The string representing the type, or NULL if the type is unknown. > > + * Return: > > + * * The string representing the type, or > > + * * NULL if the type is unknown. > > %NULL > would be better here, but not required. > Hi Randy, I don't see %NULL in Documentation/ (I git-grep-ed it but none found). What should I do when I have to explain NULL in Return: section of kernel-doc comment? -- An old man doll... just what I always wanted! - Clara