From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE537E for ; Mon, 15 Aug 2022 17:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MXNuYNMsVlTl4n7W8GHGr1bQEFwqfgp2A0ExRIF23qk=; b=qXeNvC+T5gA3BMHrvTz7QklUoi zSJhfDsa/e/YFM28wZKpazCPqwXfUaLKWQmqKbkQ6uWUpHc2qXniG48txxPhRSLJg4OWt9sER60tV YrBPEmy07SDMpzT2YbwPSY3tcG/1esOvN5peb//b/TwWDUx6nRU3n8//5T3zm6hsnVMs3ZFp6VN6b Z6CoE4/2UE9Ehi8mz9zoq9uujaSDUSg0wmdapR/wgQmuzoVOcbgpJId3Z9B8OHpCMEKcnR3IHgQ07 WA5NdTHPxSFHgeXkh9AG0ojwCik46XFa74EJ3B0q/MkNRS0ceKf38TLFEiNGR6UDUGpw050FKsrpH 58N98aJg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNeHm-002j9M-Mc; Mon, 15 Aug 2022 17:53:58 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 7DDF0980264; Mon, 15 Aug 2022 19:53:55 +0200 (CEST) Date: Mon, 15 Aug 2022 19:53:55 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Al Viro , Nathan Chancellor , Nick Desaulniers , Jeff Layton , Ilya Dryomov , ceph-devel@vger.kernel.org, Linux Kernel Mailing List , Matthew Wilcox , clang-built-linux Subject: Re: Simplify load_unaligned_zeropad() (was Re: [GIT PULL] Ceph updates for 5.20-rc1) Message-ID: References: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 15, 2022 at 08:58:21AM -0700, Linus Torvalds wrote: > The other question I had was actually the "return false" above - I > decided that if the address of the fault does *not* match the expected > "round %rdx up" address, we shouldn't do any fixup at all, and treat > it as a regular kernel oops - as if the exception table hadn't been > found at all. Ah yes, I did see that and I agree, that seems like the right thing to do.