Re: [PATCH v2] ASoC: codecs: add uspport for the TI SRC4392 codec

[Nathan Chancellor <nathan@kernel.org>]

On Mon, Aug 22, 2022 at 07:09:05PM +0100, Mark Brown wrote:
> On Wed, Aug 17, 2022 at 08:45:51AM -0700, Nathan Chancellor wrote:
> > On Wed, Aug 17, 2022 at 03:44:33PM +1000, Matt Flax wrote:
> > > On 17/8/22 04:00, Nathan Chancellor wrote:
> 
> > > > In the final commit, there is a 'break' here. Should it be a 'return 0'
> > > > instead? Or should there be a different fix for these warnings?
> 
> > > The state of DIR PLL registers aren't important if the user doesn't specify
> > > a known mclk frequency.  The implication is that the DIR will not function,
> > > however that is already implied by the user lacking to specify a known mclk
> > > frequency.
> 
> > > The other functions on the chip (port A/B I2S, SRC, DIT, etc) will behave as
> > > per usual, only the DIR will be dysfunctional.
> 
> > So I suppose there is little point to all of the calls to regmap_write()
> > and regmap_update_bits() in the default case then, meaning a 'return 0'
> > would be appropriate? Sorry, I am having a hard time parsing what should
> > be done about the warnings, which are fatal for allmodconfig due to
> > CONFIG_WERROR.
> 
> Are either of you still looking at fixing this?

I sent https://lore.kernel.org/20220822183101.1115095-1-nathan@kernel.org/.

If that is not the right fix, I need some guidance on what it should be.

Cheers,
Nathan