From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08A467B for ; Thu, 29 Sep 2022 23:22:45 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id b75so2749193pfb.7 for ; Thu, 29 Sep 2022 16:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=k9iVNCg81C1n4ax6HQVaWzPvcQNvg+2Jo/FvkuXEunA=; b=ZG7Il9MJjhiZYW6rmuir8dLrJp8mtTxzNUqHaNt2KJbdXb0Vqv0ZZwEq4xwit/7/kx hxkzj/nOKCWNHp72GCvO/DCoYljFBbXN3J3vBy/4DJrdwk2amR1P1fOSm3hKsWejd76U lC6h1j4tQfJ9oM03CSqKfETN+fvlytyBlGiw5vXQ6ZEmrG7BA1ISkOg50x7taHsy3tiQ OpCroDSUw+mnxyBOGKwEEuMV4FYnwkyHtdBgcwmHCAyRbwOQH5sYQ4+B23q6EemAOpmE K9dq+jajWeU+uERQ0gYfz1lSFNRLdbgAMsRNs8LcTTmOsD+WfjzKuXR9IcbL2t3/6vtV AWwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=k9iVNCg81C1n4ax6HQVaWzPvcQNvg+2Jo/FvkuXEunA=; b=YQbDz++4Y4mqk2MbIEy+GpsPWQJ+4wXoPghR8oAoN6aL2PAA/gNRlNS+fCdQKD69CW sk0UlbGWkDr5i5azC3MwpceN49dhuEBfLwROdtZRxMU8WYAk7iVI3B0sjHuGzQAeOpMG DWgeEIG7pV59wAYFr19fflkdA182wqCxi0ji8Nb1lzcVCKjklIwiPIM6c6Vw1zs6zS81 1JNY9Z3jgFMtaSIz/YpgyCzAauowcfQhBnxQE0livi08XdQRueN5g4JFhhG7cQG6xyLk UWtUxUTjmpiSTGp0aOzpXzMisshl4/OVIF6uULhhE8bENPupnyVOILoZC5JW8sc5lrdy 8huA== X-Gm-Message-State: ACrzQf1qG9E/4J9BUeEDUwFhpO5mrC23kMLa1SuY+MvCQwVO41GZiuau H7thxK8sRJ+ZhD566cmuwsA= X-Google-Smtp-Source: AMsMyM6cJj++MIqaW87//ChnT4eL4aY2b767/mhIM9iIEtDKUNST2lQzIBwjf2ER9kGasWWjIpHLLA== X-Received: by 2002:a63:5243:0:b0:43c:96a:8528 with SMTP id s3-20020a635243000000b0043c096a8528mr4982707pgl.47.1664493765171; Thu, 29 Sep 2022 16:22:45 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:637c:7f23:f348:a9e6]) by smtp.gmail.com with ESMTPSA id g3-20020a170902d1c300b0017a00216965sm414776plb.218.2022.09.29.16.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:22:44 -0700 (PDT) Date: Thu, 29 Sep 2022 16:22:41 -0700 From: Dmitry Torokhov To: Raul Rangel Cc: "Rafael J. Wysocki" , ACPI Devel Maling List , linux-input , Andy Shevchenko , Hans de Goede , Mika Westerberg , Mario Limonciello , Tim Van Patten , Linus Walleij , "jingle.wu" , Dan Williams , Greg Kroah-Hartman , Jonathan Cameron , Len Brown , Nathan Chancellor , Nick Desaulniers , Terry Bowman , Tom Rix , Linux Kernel Mailing List , llvm@lists.linux.dev Subject: Re: [PATCH v6 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Message-ID: References: <20220929161917.2348231-1-rrangel@chromium.org> <20220929093200.v6.6.I8092e417a8152475d13d8d638eb4c5d8ea12ac7b@changeid> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 29, 2022 at 03:20:12PM -0600, Raul Rangel wrote: > On Thu, Sep 29, 2022 at 1:38 PM Rafael J. Wysocki wrote: > > > > On Thu, Sep 29, 2022 at 9:27 PM Raul Rangel wrote: > > > > > > On Thu, Sep 29, 2022 at 1:18 PM Rafael J. Wysocki wrote: > > > > > > > > On Thu, Sep 29, 2022 at 6:19 PM Raul E Rangel wrote: > > > > > > > > > > ACPI IRQ/Interrupt resources contain a bit that describes if the > > > > > interrupt should wake the system. This change exposes that bit via > > > > > a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag > > > > > > > > I would call this IORESOURCE_IRQ_WAKE which is (a) simpler and easier > > > > to read and (b) it sort of matches the "wakeirq" naming convention. > > > > > > It was Dmitry who originally suggested the name. I personally like the > > > CAPABLE in the name. It makes it clear that it's capable of acting as > > > a wake source, not to be confused with being enabled as a wake source. > > > > Well, so be it then. > > > > As I said elsewhere, I can apply this patch too if that's useful at this point. > > > > We just need to make sure the ACPI patches 5-8 land before the i2c > patches 9-13. The i2c patches 1-4 can land before or after the ACPI > changes. I'm not sure how things get coordinated across subsystems. I am fine with all input stuff going through ACPI tree to ease landing. Or I can pick up everything if Rafael and Jiri/Benjamin agree. -- Dmitry