From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 870B125E806 for ; Tue, 25 Mar 2025 17:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742922335; cv=none; b=FVv8ITD45VFyv4hxb42wRWaSMYYaalKmQdnWvD81nuufLy8P0q+eoohBtyxvW5h2SX6jVP61RsS8V++XQQhEM/y4xDNflJZ3lFS609TrswvH4n6kvzB++Y9J0PeGgT6K8ZTPAJ9CA7bSCpP5NwyiyhdAngzer4UvNfPabYoiFi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742922335; c=relaxed/simple; bh=men12D/1UWjXP6yS9n74PB9Is6POlk2936lMrSHC3c0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k3Pbplc8hmvi6bG1tMg/xZdLG/r5amQpFghp+/cpxRGlyyfG0K0u4YdWBPSd4DsqYaoIO9UqbhATDaFNLLPn/Oxh9cdPRGfua2VbbTskt2Ww2hV6WL7FoIu9zXVn1WQjJ1CgSrvD2Gatav1uInU5RN1ZAIHXtPLmfOQne8TyH1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: /crOqIiARSOhVFv7QVshZA== X-CSE-MsgGUID: xwJFfKaOSt+iCJcJWxdk/g== X-IronPort-AV: E=McAfee;i="6700,10204,11384"; a="46920516" X-IronPort-AV: E=Sophos;i="6.14,275,1736841600"; d="scan'208";a="46920516" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2025 10:05:33 -0700 X-CSE-ConnectionGUID: haCryvQkSQODulqYUxvYNA== X-CSE-MsgGUID: Gvki/IQyT9W+5MTKydAfSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,275,1736841600"; d="scan'208";a="124413000" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2025 10:05:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tx7iS-00000005oPI-1LtT; Tue, 25 Mar 2025 19:05:28 +0200 Date: Tue, 25 Mar 2025 19:05:28 +0200 From: Andy Shevchenko To: Nathan Chancellor Cc: Kees Cook , Nick Desaulniers , Bill Wendling , Justin Stitt , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, linux-efi@vger.kernel.org Subject: Re: [PATCH RFC 2/2] wcslen() prototype in string.h Message-ID: References: <20250325-string-add-wcslen-for-llvm-opt-v1-0-b8f1e2c17888@kernel.org> <20250325-string-add-wcslen-for-llvm-opt-v1-2-b8f1e2c17888@kernel.org> <20250325165847.GA2603000@ax162> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250325165847.GA2603000@ax162> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Mar 25, 2025 at 09:58:47AM -0700, Nathan Chancellor wrote: > On Tue, Mar 25, 2025 at 06:17:34PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 25, 2025 at 08:45:19AM -0700, Nathan Chancellor wrote: ... > > > Rename the efi function to avoid the conflict. > > > > Hmm... Why not split this to two, rename patch as a standalone makes sense to > > me even outside of this series. > > How so? If nls.h is not included in printk.c via string.h, which does > not happen without this series, what value does the rename have? I do > not mind splitting it up that way to keep things cleaner, I am just > wondering what would be the justification in the changelog (I guess just > that nls.h may get included in the future for some reason)? Inside this series the justification is obvious (a.k.a. the same), outside yes something like "Put EFI specific function to the respective namespace to avoid potential clash in the future when including another header." -- With Best Regards, Andy Shevchenko