From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: sashal@kernel.org, stable@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Lecopzer Chen <lecopzer.chen@mediatek.com>
Subject: Re: [PATCH] Makefile: use -gdwarf-{4|5} for assembler for DEBUG_INFO_DWARF{4|5}
Date: Thu, 16 Mar 2023 09:24:41 +0100 [thread overview]
Message-ID: <ZBLSSWw4G86Ka6BZ@kroah.com> (raw)
In-Reply-To: <20230315214059.395939-1-ndesaulniers@google.com>
On Wed, Mar 15, 2023 at 02:40:59PM -0700, Nick Desaulniers wrote:
> This is _not_ an upstream commit and just for 5.15.y only. It is based
> on upstream
> commit 32ef9e5054ec ("Makefile.debug: re-enable debug info for .S files").
>
> When the user has chosen not to use their compiler's implicit default
> DWARF version (which changes over time) via selecting
> - CONFIG_DEBUG_INFO_DWARF4 or
> - CONFIG_DEBUG_INFO_DWARF5
> we need to tell the compiler this for Asm sources as well as C sources.
> (We use the compiler to drive assembler jobs in kbuild, since most asm
> needs to be preprocessed first). Otherwise, we will get object files
> built from Asm sources with the compiler's implicit default DWARF
> version.
>
> For example, selecting CONFIG_DEBUG_INFO_DWARF4 would produce a DWARFv5
> vmlinux, since it was a mix of DWARFv4 object files from C sources and
> DWARFv5 object files from Asm sources when using Clang as the assembler
> (ex. `make LLVM=1`).
>
> Fixes: 0ee2f0567a56 ("Makefile.debug: re-enable debug info for .S files")
> Reported-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
Now queued up, thanks,
greg k-h
prev parent reply other threads:[~2023-03-16 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 21:40 [PATCH] Makefile: use -gdwarf-{4|5} for assembler for DEBUG_INFO_DWARF{4|5} Nick Desaulniers
2023-03-16 8:24 ` Patch "Makefile: use -gdwarf-{4|5} for assembler for DEBUG_INFO_DWARF{4|5}" has been added to the 5.15-stable tree gregkh
2023-03-16 8:24 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBLSSWw4G86Ka6BZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).