* Re: [PATCH] phy: mediatek: fix returning garbage
2023-04-14 12:22 [PATCH] phy: mediatek: fix returning garbage Tom Rix
@ 2023-04-14 15:43 ` Matthias Brugger
2023-04-14 15:46 ` Matthias Brugger
2023-04-14 15:49 ` Nathan Chancellor
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Matthias Brugger @ 2023-04-14 15:43 UTC (permalink / raw)
To: Tom Rix, chunkuang.hu, p.zabel, chunfeng.yun, vkoul, kishon,
angelogioacchino.delregno, nathan, ndesaulniers, granquet
Cc: dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 14/04/2023 14:22, Tom Rix wrote:
> clang reports
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> if (ret)
> ^~~
> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>
> Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> index abfc077fb0a8..c63294e451d6 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> @@ -292,9 +292,9 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
> if (!(digital_div <= 32 && digital_div >= 1))
> return -EINVAL;
>
> - mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
> - PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> - txposdiv, digital_div);
> + ret = mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
> + PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> + txposdiv, digital_div);
> if (ret)
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] phy: mediatek: fix returning garbage
2023-04-14 15:43 ` Matthias Brugger
@ 2023-04-14 15:46 ` Matthias Brugger
0 siblings, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2023-04-14 15:46 UTC (permalink / raw)
To: Tom Rix, chunkuang.hu, p.zabel, chunfeng.yun, vkoul, kishon,
angelogioacchino.delregno, nathan, ndesaulniers, granquet
Cc: dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 14/04/2023 17:43, Matthias Brugger wrote:
>
>
> On 14/04/2023 14:22, Tom Rix wrote:
>> clang reports
>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
>> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>> if (ret)
>> ^~~
>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>>
>> Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
Please also add
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
see CA+G9fYu4o0-ZKSthi7kdCjz_kFazZS-rn17Z2NPz3=1Oayr9cw@mail.gmail.com
Regards,
Matthias
>> ---
>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
>> b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
>> index abfc077fb0a8..c63294e451d6 100644
>> --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
>> +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
>> @@ -292,9 +292,9 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy
>> *hdmi_phy, struct clk_hw *hw,
>> if (!(digital_div <= 32 && digital_div >= 1))
>> return -EINVAL;
>> - mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
>> - PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
>> - txposdiv, digital_div);
>> + ret = mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
>> + PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
>> + txposdiv, digital_div);
>> if (ret)
>> return -EINVAL;
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] phy: mediatek: fix returning garbage
2023-04-14 12:22 [PATCH] phy: mediatek: fix returning garbage Tom Rix
2023-04-14 15:43 ` Matthias Brugger
@ 2023-04-14 15:49 ` Nathan Chancellor
2023-04-17 7:38 ` AngeloGioacchino Del Regno
2023-05-05 9:28 ` Vinod Koul
3 siblings, 0 replies; 10+ messages in thread
From: Nathan Chancellor @ 2023-04-14 15:49 UTC (permalink / raw)
To: Tom Rix
Cc: chunkuang.hu, p.zabel, chunfeng.yun, vkoul, kishon, matthias.bgg,
angelogioacchino.delregno, ndesaulniers, granquet, dri-devel,
linux-mediatek, linux-arm-kernel, linux-phy, linux-kernel, llvm
On Fri, Apr 14, 2023 at 08:22:53AM -0400, Tom Rix wrote:
> clang reports
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> if (ret)
> ^~~
> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>
> Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Angelo brought up a good point on another patch to fix this issue that
we should probably be returning ret instead of unconditionally returning
-EINVAL but it sounds like it does not really matter at the moment since
mtk_hdmi_pll_set_hw() can only return -EINVAL or 0.
https://lore.kernel.org/ada769e0-0141-634f-3753-eb3a50f0eee3@collabora.com/
> ---
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> index abfc077fb0a8..c63294e451d6 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
> @@ -292,9 +292,9 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
> if (!(digital_div <= 32 && digital_div >= 1))
> return -EINVAL;
>
> - mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
> - PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> - txposdiv, digital_div);
> + ret = mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
> + PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> + txposdiv, digital_div);
> if (ret)
> return -EINVAL;
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] phy: mediatek: fix returning garbage
2023-04-14 12:22 [PATCH] phy: mediatek: fix returning garbage Tom Rix
2023-04-14 15:43 ` Matthias Brugger
2023-04-14 15:49 ` Nathan Chancellor
@ 2023-04-17 7:38 ` AngeloGioacchino Del Regno
2023-05-05 9:28 ` Vinod Koul
3 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-04-17 7:38 UTC (permalink / raw)
To: Tom Rix, chunkuang.hu, p.zabel, chunfeng.yun, vkoul, kishon,
matthias.bgg, nathan, ndesaulniers, granquet
Cc: dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
Il 14/04/23 14:22, Tom Rix ha scritto:
> clang reports
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> if (ret)
> ^~~
> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>
> Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] phy: mediatek: fix returning garbage
2023-04-14 12:22 [PATCH] phy: mediatek: fix returning garbage Tom Rix
` (2 preceding siblings ...)
2023-04-17 7:38 ` AngeloGioacchino Del Regno
@ 2023-05-05 9:28 ` Vinod Koul
2023-05-05 15:37 ` Matthias Brugger
3 siblings, 1 reply; 10+ messages in thread
From: Vinod Koul @ 2023-05-05 9:28 UTC (permalink / raw)
To: Tom Rix
Cc: chunkuang.hu, p.zabel, chunfeng.yun, kishon, matthias.bgg,
angelogioacchino.delregno, nathan, ndesaulniers, granquet,
dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 14-04-23, 08:22, Tom Rix wrote:
> clang reports
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> if (ret)
> ^~~
> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
usage in pll_calc"
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] phy: mediatek: fix returning garbage
2023-05-05 9:28 ` Vinod Koul
@ 2023-05-05 15:37 ` Matthias Brugger
2023-05-08 7:48 ` Vinod Koul
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Brugger @ 2023-05-05 15:37 UTC (permalink / raw)
To: Vinod Koul, Tom Rix
Cc: chunkuang.hu, p.zabel, chunfeng.yun, kishon,
angelogioacchino.delregno, nathan, ndesaulniers, granquet,
dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 05/05/2023 11:28, Vinod Koul wrote:
> On 14-04-23, 08:22, Tom Rix wrote:
>> clang reports
>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
>> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>> if (ret)
>> ^~~
>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>
> I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
> usage in pll_calc"
Thanks Vinod, that was on my list for today as well. I was a bit puzzled because
you took the patch that added it, but I wasn't sure if you would take the fix.
How do you want to handle things like this in the future?
Regards,
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] phy: mediatek: fix returning garbage
2023-05-05 15:37 ` Matthias Brugger
@ 2023-05-08 7:48 ` Vinod Koul
2023-05-08 8:24 ` Matthias Brugger
0 siblings, 1 reply; 10+ messages in thread
From: Vinod Koul @ 2023-05-08 7:48 UTC (permalink / raw)
To: Matthias Brugger
Cc: Tom Rix, chunkuang.hu, p.zabel, chunfeng.yun, kishon,
angelogioacchino.delregno, nathan, ndesaulniers, granquet,
dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 05-05-23, 17:37, Matthias Brugger wrote:
>
>
> On 05/05/2023 11:28, Vinod Koul wrote:
> > On 14-04-23, 08:22, Tom Rix wrote:
> > > clang reports
> > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> > > 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> > > if (ret)
> > > ^~~
> > > ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
> >
> > I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
> > usage in pll_calc"
>
> Thanks Vinod, that was on my list for today as well. I was a bit puzzled
> because you took the patch that added it, but I wasn't sure if you would
> take the fix. How do you want to handle things like this in the future?
Fixes should be sent as Fixes patch
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] phy: mediatek: fix returning garbage
2023-05-08 7:48 ` Vinod Koul
@ 2023-05-08 8:24 ` Matthias Brugger
2023-05-08 8:57 ` Vinod Koul
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Brugger @ 2023-05-08 8:24 UTC (permalink / raw)
To: Vinod Koul
Cc: Tom Rix, chunkuang.hu, p.zabel, chunfeng.yun, kishon,
angelogioacchino.delregno, nathan, ndesaulniers, granquet,
dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 08/05/2023 09:48, Vinod Koul wrote:
> On 05-05-23, 17:37, Matthias Brugger wrote:
>>
>>
>> On 05/05/2023 11:28, Vinod Koul wrote:
>>> On 14-04-23, 08:22, Tom Rix wrote:
>>>> clang reports
>>>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
>>>> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>>>> if (ret)
>>>> ^~~
>>>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>>>
>>> I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
>>> usage in pll_calc"
>>
>> Thanks Vinod, that was on my list for today as well. I was a bit puzzled
>> because you took the patch that added it, but I wasn't sure if you would
>> take the fix. How do you want to handle things like this in the future?
>
> Fixes should be sent as Fixes patch
>
I'm not sure what do you mean. Patch subject includes the word fix and the patch
has a fixes tag. What was missing here?
Does this mean you will take fixes for this driver in the future or do you want
me to take care of them?
Regards,
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] phy: mediatek: fix returning garbage
2023-05-08 8:24 ` Matthias Brugger
@ 2023-05-08 8:57 ` Vinod Koul
0 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2023-05-08 8:57 UTC (permalink / raw)
To: Matthias Brugger
Cc: Tom Rix, chunkuang.hu, p.zabel, chunfeng.yun, kishon,
angelogioacchino.delregno, nathan, ndesaulniers, granquet,
dri-devel, linux-mediatek, linux-arm-kernel, linux-phy,
linux-kernel, llvm
On 08-05-23, 10:24, Matthias Brugger wrote:
>
>
> On 08/05/2023 09:48, Vinod Koul wrote:
> > On 05-05-23, 17:37, Matthias Brugger wrote:
> > >
> > >
> > > On 05/05/2023 11:28, Vinod Koul wrote:
> > > > On 14-04-23, 08:22, Tom Rix wrote:
> > > > > clang reports
> > > > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
> > > > > 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
> > > > > if (ret)
> > > > > ^~~
> > > > > ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
> > > >
> > > > I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
> > > > usage in pll_calc"
> > >
> > > Thanks Vinod, that was on my list for today as well. I was a bit puzzled
> > > because you took the patch that added it, but I wasn't sure if you would
> > > take the fix. How do you want to handle things like this in the future?
> >
> > Fixes should be sent as Fixes patch
> >
>
> I'm not sure what do you mean. Patch subject includes the word fix and the
> patch has a fixes tag. What was missing here?
>
> Does this mean you will take fixes for this driver in the future or do you
> want me to take care of them?
Yes I would take the fixes as well for the drivers
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread