From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC873C22 for ; Mon, 8 May 2023 08:57:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54E10C433EF; Mon, 8 May 2023 08:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683536267; bh=G5v7NSAKXe2kLiZkicPjPQ/vKtmbjwfgIRwrsi4rT4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pl0UQZj54buaQ35xQcBdmpJB5ccWsOHmiWJ7iamjj1B4SoCPRo1KbNe+Aukzlc5n0 uZMuGpJNslVEQWFdp6SVSfIhl/01niiqlSnP43z5Z5MyWpV91e66gqMkOJI237gRtj ar6LG2CQu7g7xRL4EVmpPL6H0s6z659skAJLJikwHvbbxMh5NnoDKthlZjFvuauR+7 UHGLwXIF475Aupcf11AcKtW9W9LVMZcZPTlUgJmb7cx5K+Z1MqjMjPoxtdohoSGWUu ZnDq6Q2bic907kFa2sq5IqN5KB4gpocS4VZx3rcrWCAuBmKvVpfnAgAuP+NM0k8+Ce lE1EgjLr+fVPg== Date: Mon, 8 May 2023 14:27:42 +0530 From: Vinod Koul To: Matthias Brugger Cc: Tom Rix , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, chunfeng.yun@mediatek.com, kishon@kernel.org, angelogioacchino.delregno@collabora.com, nathan@kernel.org, ndesaulniers@google.com, granquet@baylibre.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] phy: mediatek: fix returning garbage Message-ID: References: <20230414122253.3171524-1-trix@redhat.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 08-05-23, 10:24, Matthias Brugger wrote: > > > On 08/05/2023 09:48, Vinod Koul wrote: > > On 05-05-23, 17:37, Matthias Brugger wrote: > > > > > > > > > On 05/05/2023 11:28, Vinod Koul wrote: > > > > On 14-04-23, 08:22, Tom Rix wrote: > > > > > clang reports > > > > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable > > > > > 'ret' is uninitialized when used here [-Werror,-Wuninitialized] > > > > > if (ret) > > > > > ^~~ > > > > > ret should have been set by the preceding call to mtk_hdmi_pll_set_hw. > > > > > > > > I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable > > > > usage in pll_calc" > > > > > > Thanks Vinod, that was on my list for today as well. I was a bit puzzled > > > because you took the patch that added it, but I wasn't sure if you would > > > take the fix. How do you want to handle things like this in the future? > > > > Fixes should be sent as Fixes patch > > > > I'm not sure what do you mean. Patch subject includes the word fix and the > patch has a fixes tag. What was missing here? > > Does this mean you will take fixes for this driver in the future or do you > want me to take care of them? Yes I would take the fixes as well for the drivers -- ~Vinod