* Re: [PATCH] scsi: ufs: qcom: remove unused variable
[not found] <20230724122029.1430482-1-arnd@kernel.org>
@ 2023-07-25 21:53 ` Nick Desaulniers
0 siblings, 0 replies; only message in thread
From: Nick Desaulniers @ 2023-07-25 21:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
James E.J. Bottomley, Martin K. Petersen, Ziqi Chen, Can Guo,
Arnd Bergmann, Asutosh Das, Andrew Halaney, Abel Vesa,
linux-arm-msm, linux-scsi, linux-kernel, llvm
On Mon, Jul 24, 2023 at 02:19:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change removed the only user of a local variable that needs
> to now also be removed:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]
>
> Fixes: 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch!
Reported-by: kernelci.org bot <bot@kernelci.org>
Link: https://lore.kernel.org/llvm/64c00cd4.630a0220.6ad79.0eac@mx.google.com/
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/ufs/host/ufs-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 3ee5ff905f9a6..5728e94b6527b 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
> struct msi_desc *desc = data;
> struct device *dev = msi_desc_to_dev(desc);
> struct ufs_hba *hba = dev_get_drvdata(dev);
> - struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> u32 id = desc->msi_index;
> struct ufs_hw_queue *hwq = &hba->uhq[id];
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] only message in thread