Re: [PATCH nf] netfilter: nf_tables: GC transaction race with abort path

kernel test robot
2023-08-18T07:49:40Z

Hi Pablo,

kernel test robot noticed the following build errors:

[auto build test ERROR on nf/master]

url: https://github.com/intel-lab-lkp/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_tables-GC-transaction-race-with-abort-path/20230818-071545
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
patch link: https://lore.kernel.org/r/20230817231352.8412-1-pablo%40netfilter.org
patch subject: [PATCH nf] netfilter: nf_tables: GC transaction race with abort path
config: hexagon-randconfig-r045-20230818 (https://download.01.org/0day-ci/archive/20230818/202308181545.lZbeE7Lm-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308181545.lZbeE7Lm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308181545.lZbeE7Lm-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/netfilter/nf_tables_api.c:9132:11: error: call to undeclared function 'nft_gc_seq_begin'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
9132 | gc_seq = nft_gc_seq_begin(nft_net);
| ^
>> net/netfilter/nf_tables_api.c:9134:2: error: call to undeclared function 'nft_gc_seq_end'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
9134 | nft_gc_seq_end(nft_net, gc_seq);
| ^
2 errors generated.

vim +/nft_gc_seq_begin +9132 net/netfilter/nf_tables_api.c

9124
9125 static int nf_tables_abort(struct net *net, struct sk_buff *skb,
9126 enum nfnl_abort_action action)
9127 {
9128 struct nftables_pernet *nft_net = nft_pernet(net);
9129 unsigned int gc_seq;
9130 int ret;
9131
> 9132 gc_seq = nft_gc_seq_begin(nft_net);
9133 ret = __nf_tables_abort(net, action);
> 9134 nft_gc_seq_end(nft_net, gc_seq);
9135 mutex_unlock(&nft_net->commit_mutex);
9136
9137 return ret;
9138 }
9139

--
0-DAY CI Kernel Test Service