From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48CE511701 for ; Fri, 11 Aug 2023 16:09:47 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3fe5c0e5747so13070605e9.0 for ; Fri, 11 Aug 2023 09:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691770185; x=1692374985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=gj6RcIM5t5nz3eaWtpxz9vjlj23IfmgvBZ8zsd7klI8=; b=muVl4Xl+lTMTvOpFocZFUmDiEvnMOY8PFCuwOkx56ORPFHaWulsQfIHWvc2KpPJg+w DpFVVQ782tZV/qB4bHcFQST3Zx9E+SPLPnwLmx+lsPpCISssU1ZZTRs62PGarbC4B2XM xZMnNyH10k0bZro92O6fshpbenTntEIOere/zh32An0uUBQeMiDdgfbXDmdBNpI7kwcC JJ2ZEZz5VuY84U5BSvPG62mKY3hZJX/aoqJ+3Bs3XWBzbKLIQs+okNRY/DSKFAEzq4Lv oNxtAWi9hQqmuIYCQoKSqAbeYAgotyS4g9DPbshX1Y3+MB29QEa6aDKrdlrlSM/EVmiG hrCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691770185; x=1692374985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gj6RcIM5t5nz3eaWtpxz9vjlj23IfmgvBZ8zsd7klI8=; b=GGdgpxYnLQPom3oqD5ZdX0hbnLn/Ma4Y5RPyqNPY8lqubA0eFoysDH70YsqVrJ/7jr a8DYnJ2It5wFs638KJZRNnPhfe01xXiWKcqWLn4Hv7LdzjV+zkqI3bvzHfOYZ72s6t5r ivzJU7rKrigLaWW0XUXPd8E8NMO8IkRoNQ67UHii6Voe2ywxfCWcA7BPFpZsMNENSp+u UA1fu3zeszhsdpm0Ro49Z9tLwEjhcozTP5jf37UWB6+V/LFzNuywsTIwEd4d0CGUeMuA iU2RVDRmHt0Jve41+KnbIQZIG/YPZMtsNn0dRk831j5TNRodeW8mMnS3Hxeq1tLd6Y32 heOA== X-Gm-Message-State: AOJu0YxeJvuZkXjeEtCBQPmv0kc2bBkqve0bAThj8JGLvj4i6fy4amBN pbogFevwarTCAMx+TOVa21vjixqtQUfNqQ== X-Google-Smtp-Source: AGHT+IGcKf6v/9EVJ1A6GtZyZCJRuvnjFiatNiZiqH2sDuZt3qBsnnHi+Jv6+UD0KsEolE/9XDF+kg== X-Received: by 2002:a1c:6a14:0:b0:3fe:1c10:8d04 with SMTP id f20-20020a1c6a14000000b003fe1c108d04mr2014646wmc.19.1691770184869; Fri, 11 Aug 2023 09:09:44 -0700 (PDT) Received: from krava (ip-94-113-247-30.net.vodafone.cz. [94.113.247.30]) by smtp.gmail.com with ESMTPSA id c6-20020a7bc846000000b003fe0a0e03fcsm8419320wml.12.2023.08.11.09.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 09:09:44 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Fri, 11 Aug 2023 18:09:41 +0200 To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Fangrui Song , Anshuman Khandual , Andi Kleen , Leo Yan , Madhavan Srinivasan , Carsten Haitzler , Ravi Bangoria , "Naveen N. Rao" , Athira Rajeev , Kan Liang , Yang Jihong , James Clark , Tiezhu Yang , Eduard Zingerman , Andrii Nakryiko , Yonghong Song , Rob Herring , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, Wang Nan , Wang ShaoBo , YueHaibing , He Kuang , Brendan Gregg Subject: Re: [PATCH v1 0/4] Remove BPF event support Message-ID: References: <20230810184853.2860737-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810184853.2860737-1-irogers@google.com> On Thu, Aug 10, 2023 at 11:48:49AM -0700, Ian Rogers wrote: > The patch series removes BPF event support as past commits have shown > the support has bit rotten: > https://lore.kernel.org/lkml/20230728001212.457900-1-irogers@google.com/ > > Similar functionality is now available via the --filter option, that > uses a BPF skeleton, and is therefore more compact and simpler to > use. The simplicity coming from not having to build BPF object files. > > A different use case for the events was for syscall augmentation in > perf trace. So that this isn't broken, and to make its use > significantly simpler, the support is migrated to use a BPF > skeleton. This means perf trace is much more likely to augment > syscalls for users. > > Removal of BPF events was raised on LKML two weeks ago with the > original authors cc-ed: > https://lore.kernel.org/lkml/CAP-5=fXxGimJRXKf7bcaPqfjxxGcn1k3CspY_iSjQnpAKs3uFQ@mail.gmail.com/ > > BPF events are described publicly in very few places but one is: > https://www.brendangregg.com/perf.html#eBPF > "eBPF is currently a little restricted and difficult to use from > perf. It's getting better all the time. A different and currently > easier way to access eBPF is via the bcc Python interface, which is > described on my eBPF Tools page. On this page, I'll discuss perf." > > I don't think the "getting better all the time" is any longer true as > BPF features are being added to perf primarily by using BPF > skeletons. The given example is a filter and would be better supported > via "perf record --filter". agreed, I don't think it's being really used as well, also caused problems with libbpf updates > > Ian Rogers (4): > perf parse-events: Remove BPF event support > perf trace: Migrate BPF augmentation to use a skeleton > perf bpf examples: With no BPF events remove examples > perf trace: Tidy comments > > tools/perf/Documentation/perf-config.txt | 33 - > tools/perf/Documentation/perf-record.txt | 22 - > tools/perf/Makefile.config | 43 - > tools/perf/Makefile.perf | 19 +- > tools/perf/builtin-record.c | 45 - > tools/perf/builtin-trace.c | 310 +-- > tools/perf/examples/bpf/5sec.c | 53 - > tools/perf/examples/bpf/empty.c | 12 - > tools/perf/examples/bpf/hello.c | 27 - > tools/perf/examples/bpf/sys_enter_openat.c | 33 - > tools/perf/perf.c | 2 - > tools/perf/tests/.gitignore | 5 - > tools/perf/tests/Build | 31 - > tools/perf/tests/bpf-script-example.c | 60 - > tools/perf/tests/bpf-script-test-kbuild.c | 21 - > tools/perf/tests/bpf-script-test-prologue.c | 49 - > tools/perf/tests/bpf-script-test-relocation.c | 51 - > tools/perf/tests/bpf.c | 390 ---- > tools/perf/tests/builtin-test.c | 3 - > tools/perf/tests/clang.c | 32 - > tools/perf/tests/llvm.c | 219 -- > tools/perf/tests/llvm.h | 31 - > tools/perf/tests/make | 2 - > tools/perf/tests/tests.h | 2 - > tools/perf/trace/beauty/beauty.h | 15 +- > tools/perf/util/Build | 8 +- > tools/perf/util/bpf-loader.c | 2006 ----------------- > tools/perf/util/bpf-loader.h | 216 -- > .../bpf_skel/augmented_raw_syscalls.bpf.c} | 35 +- > tools/perf/util/c++/Build | 5 - > tools/perf/util/c++/clang-c.h | 43 - > tools/perf/util/c++/clang-test.cpp | 67 - > tools/perf/util/c++/clang.cpp | 225 -- > tools/perf/util/c++/clang.h | 27 - > tools/perf/util/config.c | 4 - > tools/perf/util/llvm-utils.c | 612 ----- > tools/perf/util/llvm-utils.h | 69 - > tools/perf/util/parse-events.c | 268 --- > tools/perf/util/parse-events.h | 15 - > tools/perf/util/parse-events.l | 31 - > tools/perf/util/parse-events.y | 44 +- > 41 files changed, 133 insertions(+), 5052 deletions(-) awesome :)) Acked-by: Jiri Olsa thanks, jirka > delete mode 100644 tools/perf/examples/bpf/5sec.c > delete mode 100644 tools/perf/examples/bpf/empty.c > delete mode 100644 tools/perf/examples/bpf/hello.c > delete mode 100644 tools/perf/examples/bpf/sys_enter_openat.c > delete mode 100644 tools/perf/tests/.gitignore > delete mode 100644 tools/perf/tests/bpf-script-example.c > delete mode 100644 tools/perf/tests/bpf-script-test-kbuild.c > delete mode 100644 tools/perf/tests/bpf-script-test-prologue.c > delete mode 100644 tools/perf/tests/bpf-script-test-relocation.c > delete mode 100644 tools/perf/tests/bpf.c > delete mode 100644 tools/perf/tests/clang.c > delete mode 100644 tools/perf/tests/llvm.c > delete mode 100644 tools/perf/tests/llvm.h > delete mode 100644 tools/perf/util/bpf-loader.c > delete mode 100644 tools/perf/util/bpf-loader.h > rename tools/perf/{examples/bpf/augmented_raw_syscalls.c => util/bpf_skel/augmented_raw_syscalls.bpf.c} (93%) > delete mode 100644 tools/perf/util/c++/Build > delete mode 100644 tools/perf/util/c++/clang-c.h > delete mode 100644 tools/perf/util/c++/clang-test.cpp > delete mode 100644 tools/perf/util/c++/clang.cpp > delete mode 100644 tools/perf/util/c++/clang.h > delete mode 100644 tools/perf/util/llvm-utils.c > delete mode 100644 tools/perf/util/llvm-utils.h > > -- > 2.41.0.640.ga95def55d0-goog >