Re: [akpm-mm:mm-stable 219/240] mm/memory.c:5410:34: error: call to undeclared function 'vma_is_tcp'; ISO C99 and later do not support implicit function declarations

Matthew Wilcox
2023-08-12T15:56:36Z

On Sat, Aug 12, 2023 at 07:40:10PM +0800, kernel test robot wrote:
> >> mm/memory.c:5410:34: error: call to undeclared function 'vma_is_tcp'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 5410 | if (unlikely(!vma->anon_vma && !vma_is_tcp(vma)))
> | ^

This is a mismerge. This patch will fix.

diff --git a/mm/memory.c b/mm/memory.c
index f06266464208..004b2e5dfef3 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -5456,7 +5456,7 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm,
* concurrent mremap() with MREMAP_DONTUNMAP could dissociate the VMA
* from its anon_vma.
*/
- if (unlikely(!vma->anon_vma && !vma_is_tcp(vma)))
+ if (vma_is_anonymous(vma) && !vma->anon_vma)
goto inval_end_read;

/*