From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF2ACA6C;
	Sat, 23 Sep 2023 09:03:19 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B861C433C8;
	Sat, 23 Sep 2023 09:03:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1695459798;
	bh=XWuqzQIj1H8eXCsv7k6yfzTfypuHPrX+X4bs0NkW8Sg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=c1bGaH7waBdWEhB9tGkxARlXmv2I82G7hAGMnsAGEQZs4r3SQu8+f8XKXEEBHmzBl
	 nUQiZSd7C5g4HMSHoRo5goJt0quD80GJOkKP45aIy1+cx/PZ4wcjpXIB5V5Dszy6X7
	 Up7NG1SWcK6B9JfqgIHEnx6mqN8Sw4WpGvtFujsRBFPLpAi/3biSWSqwdO2FHzD//y
	 wrIW90fmE/a7Z121YhPrW4olrPH37nfxRKTrfYvkkA5LnFVTEfa9Ne7kva3knAqfgu
	 SmoddciSNHlQ1Ur/Pp9mxvUmBbqAw6nab7WApbDMIm816Zt44VYgd0N2LnuKtTiBxl
	 f0OjvjakKt2aQ==
Date: Sat, 23 Sep 2023 11:04:21 -0600
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Sebastian Reichel <sre@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-pm@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] power: supply: axp20x_ac_power: Annotate struct
 axp20x_ac_power with __counted_by
Message-ID: <ZQ8alYwdOfRAUnIa@work>
References: <20230922175355.work.006-kees@kernel.org>
Precedence: bulk
X-Mailing-List: llvm@lists.linux.dev
List-Id: <llvm.lists.linux.dev>
List-Subscribe: <mailto:llvm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:llvm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230922175355.work.006-kees@kernel.org>

On Fri, Sep 22, 2023 at 10:53:55AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct axp20x_ac_power.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks
--
Gustavo

> ---
>  drivers/power/supply/axp20x_ac_power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/supply/axp20x_ac_power.c
> index 19a118633115..e5733cb9e19e 100644
> --- a/drivers/power/supply/axp20x_ac_power.c
> +++ b/drivers/power/supply/axp20x_ac_power.c
> @@ -45,7 +45,7 @@ struct axp20x_ac_power {
>  	struct iio_channel *acin_i;
>  	bool has_acin_path_sel;
>  	unsigned int num_irqs;
> -	unsigned int irqs[];
> +	unsigned int irqs[] __counted_by(num_irqs);
>  };
>  
>  static irqreturn_t axp20x_ac_power_irq(int irq, void *devid)
> -- 
> 2.34.1
> 
>