From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B939113FF1 for ; Thu, 7 Dec 2023 06:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="b7qtNXQA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oErw/cP3v6K5Ya8MvRoT24q1uLCEk2UvmxpABeanB3I=; b=b7qtNXQAzmhYhQLy1jF6GCwRCH QjW3MqinvyJQYA6bgI1bw6zpavs66kYaLy1RrSXUUGZWbRZFOWm57k0vGU1uMa8W1V5TwQHsvoLlz 8V2tlia9l/FQn58wQKDf6RmDPdmv6Aod5UAAnluBwN50VmzWBeZlqcvt8JW5dn7T4Ir4N4ZT+eAjC YqwIg3arRxfy+SN26sSTMoKO0XvyvfUdnmTNUOT9/VPuUvMl2558RWSer1HMtNSnONbwZuoVR6Rfv EVBM5vCbrAZojOfmzLZKUYL4y729A4j1WAFr03gocNmYnmeYz15rkDam7nFKFNLefbjO0lWMgrhIF zsmoRM9w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rB7pW-00Byao-2U; Thu, 07 Dec 2023 06:25:50 +0000 Date: Wed, 6 Dec 2023 22:25:50 -0800 From: Christoph Hellwig To: Nick Desaulniers Cc: Andrew Morton , tanzirh@google.com, Kees Cook , Andy Shevchenko , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Nick DeSaulniers , llvm@lists.linux.dev Subject: Re: [PATCH] lib/string: shrink lib/string.i via IWYU Message-ID: References: <20231205-libstringheader-v1-1-7f9c573053a7@gmail.com> <20231205130449.8e330a26ecbed1f7b5ad5d7a@linux-foundation.org> <20231205132452.418722bea8f6878dca88142a@linux-foundation.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Dec 05, 2023 at 01:39:47PM -0800, Nick Desaulniers wrote: > Hmm...how does one know that linux/bits.h is the higher-level include > of asm/bitsperlong.h? I think this the wrong way of thinking. In general we should always avoid including asm/ headers unless there is no other way. No other way is not formalized right now, but I think the answer is roughly if no linux/ headers includes that asm header. This will probably give a few wrong results at the moment, but it's probably worth fixing them up.