From: Andy Shevchenko <andy@kernel.org>
To: tanzirh@google.com
Cc: Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick DeSaulniers <nnn@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
llvm@lists.linux.dev, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3 1/2] kernel.h: removed REPEAT_BYTE from kernel.h
Date: Tue, 19 Dec 2023 17:50:35 +0200 [thread overview]
Message-ID: <ZYG7y0A0lzzN0GqR@smile.fi.intel.com> (raw)
In-Reply-To: <20231218-libstringheader-v3-1-500bd58f0f75@google.com>
On Mon, Dec 18, 2023 at 06:44:47PM +0000, tanzirh@google.com wrote:
> This patch creates wordpart.h and includes it in asm/word-at-a-time.h
> for the all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h
> because of REPEAT_BYTE. Moving this to another header and including it
> where necessary allows us to not include the bloated kernel.h. Making
> this implicit dependancy on REPEAT_BYTE explicit allows for later
> improvements in the lib/string.c inclusion list.
...
> #include <linux/kernel.h>
> +#include <linux/wordpart.h>
Expected is to get rid of kernel.h completely.
For instance, in arch/arm/include/asm/word-at-a-time.h case this
should become:
#include <linux/bitops.h>
#include <linux/wordpart.h>
(Briefly looking the same is for include/asm-generic/word-at-a-time.h)
And so on...
...
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -39,13 +39,6 @@
> -/**
> - * REPEAT_BYTE - repeat the value @x multiple times as an unsigned long value
> - * @x: value to repeat
> - *
> - * NOTE: @x is not checked for > 0xff; larger values produce odd results.
> - */
> -#define REPEAT_BYTE(x) ((~0ul / 0xff) * (x))
Okay, we don't back include because we changing all the users at once.
...
> +++ b/include/linux/wordpart.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2023 Google LLC <tanzirh@google.com>
> + */
Can be on a single line.
Is it? Personally I skip this from the split headers, but I'm not your lawyer.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-19 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 18:44 [PATCH v3 0/2] shrink lib/string.i via IWYU tanzirh
2023-12-18 18:44 ` [PATCH v3 1/2] kernel.h: removed REPEAT_BYTE from kernel.h tanzirh
2023-12-18 20:26 ` Greg KH
2023-12-19 15:50 ` Andy Shevchenko [this message]
2023-12-18 18:44 ` [PATCH v3 2/2] lib/string: shrink lib/string.i via IWYU tanzirh
2023-12-19 15:55 ` Andy Shevchenko
2023-12-19 16:43 ` Nick Desaulniers
2023-12-21 16:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYG7y0A0lzzN0GqR@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox