Re: [phy:next 32/34] drivers/phy/rockchip/phy-rockchip-usbdp.c:1292:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true

[Vinod Koul <vkoul@kernel.org>]

On 14-04-24, 18:05, Sebastian Reichel wrote:
> Hello Vinod,
> 
> On Sun, Apr 14, 2024 at 10:31:04AM +0800, kernel test robot wrote:
> > >> drivers/phy/rockchip/phy-rockchip-usbdp.c:1292:6: warning: variable 'ret' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized]
> >     1292 |         if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) {
> >          |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]
> 
> > vim +1292 drivers/phy/rockchip/phy-rockchip-usbdp.c
> > 
> >   1284	
> >   1285	static int rk_udphy_usb3_phy_init(struct phy *phy)
> >   1286	{
> >   1287		struct rk_udphy *udphy = phy_get_drvdata(phy);
> >   1288		int ret;
> 
> I dropped the '= 0;' by your request. Based on the upper bug
> report I will just send a patch readding it. Is that fine
> with you?

Yeah I missed the goto statement which would require this..
Btw looking at the code again, why would we not power on the phy in case
of DP or hig speed?

Btw, yes patch to fix would be welcome

-- 
~Vinod