From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Simon Horman <horms@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jeroen de Borst <jeroendb@google.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
Shailend Chand <shailend@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Kees Cook <keescook@chromium.org>, <netdev@vger.kernel.org>,
<llvm@lists.linux.dev>, <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] gve: Minor cleanups
Date: Tue, 7 May 2024 19:08:01 +0200 [thread overview]
Message-ID: <Zjpf8TqVqt8aCsOp@lzaremba-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <20240503-gve-comma-v1-0-b50f965694ef@kernel.org>
On Fri, May 03, 2024 at 09:31:25PM +0100, Simon Horman wrote:
> Hi,
>
> This short patchset provides two minor cleanups for the gve driver.
>
> These were found by tooling as mentioned in each patch,
> and otherwise by inspection.
>
> No change in run time behaviour is intended.
> Each patch is compile tested only.
>
Both patches look fine to me.
Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
> ---
> Simon Horman (2):
> gve: Avoid unnecessary use of comma operator
> gve: Use ethtool_sprintf/puts() to fill stats strings
>
> drivers/net/ethernet/google/gve/gve_adminq.c | 4 +--
> drivers/net/ethernet/google/gve/gve_ethtool.c | 42 +++++++++++----------------
> 2 files changed, 19 insertions(+), 27 deletions(-)
>
> base-commit: 5829614a7b3b2cc9820efb2d29a205c00d748fcf
>
>
next prev parent reply other threads:[~2024-05-07 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 20:31 [PATCH net-next 0/2] gve: Minor cleanups Simon Horman
2024-05-03 20:31 ` [PATCH net-next 1/2] gve: Avoid unnecessary use of comma operator Simon Horman
2024-05-03 20:40 ` Dan Carpenter
2024-05-03 20:31 ` [PATCH net-next 2/2] gve: Use ethtool_sprintf/puts() to fill stats strings Simon Horman
2024-05-07 17:08 ` Larysa Zaremba [this message]
2024-05-07 19:00 ` [PATCH net-next 0/2] gve: Minor cleanups Shailend Chand
2024-05-07 22:28 ` Jakub Kicinski
2024-05-08 8:22 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjpf8TqVqt8aCsOp@lzaremba-mobl.ger.corp.intel.com \
--to=larysa.zaremba@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jeroendb@google.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox