From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1451A1A3041 for ; Thu, 5 Sep 2024 17:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725555708; cv=none; b=s7OOSGTgBfw/wrBT/e3wFnrggY3u86ed0yKVD5Y8cbafmidM03ATax0iNs0LCdtLuI1cecqHrrnNHrvFMIcXjbxUCIHI041zGniRRjwdKJmEs5IQTlKyXjPIrhP5AZrwFRelAbfDFXjZ+HaAj4G20QGT7Ofk8HgwvZEVDD3m2GA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725555708; c=relaxed/simple; bh=7aNNO97plgO44jLqRSUeQzdS2MqW2ZCGfSpP/lTtvgg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MzaB0NyzHh7bum0tDiNpWXiRlm6QqVHRcn0bZs91QIinxgxtTDlkXVfr77XWzaxl2ZV8t5lAeRTQcVBXQ2YElpj66RYRJKOsDDAsIUL297MKwXYwyDE1vCzyOJsusAtF6q+Hle97Rb8PXxFYMG9QSEiCN7vo4vSw/KOnaNPLsrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FgWr2Dkw; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FgWr2Dkw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725555707; x=1757091707; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7aNNO97plgO44jLqRSUeQzdS2MqW2ZCGfSpP/lTtvgg=; b=FgWr2DkwyMSjCmdsC2LQX+VEmdB0JBUOEjWlJiEcJiq8GqOawu4oGAZm Ayrq4fEABPyela//tGHU4eZ0nXn2fcu4bdnVhY84h6Jz47YDErunzdZYS DLGVN3qwlTuLtIE/QmHMz1hUT3UyZfRt8E0EQho5whfeu9FkLXZ1L2wHt qm+XcMYxyCT4c6l3hnHOSljAqRcqDYiCQTpoGDS1zGzUXcfIAXEKF8fbe N5Mv/rNKzJuUIoCQ8UXCVdNY6lYh9AC6hL7V5HcnoJNwcKidu5vbKdSfg EJ3P9v9avQEwhwix6zQE7FFB4xAWYU3zwO672OQgz1HNXY7dGyGZLhQ2Z A==; X-CSE-ConnectionGUID: WKaacA+PSGeOfN60P4EBVg== X-CSE-MsgGUID: YLPIbgv6Qg6ily1asQavLw== X-IronPort-AV: E=McAfee;i="6700,10204,11186"; a="24163661" X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="24163661" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 10:01:30 -0700 X-CSE-ConnectionGUID: 6pFiR2YrQq2riDLwhz3vfg== X-CSE-MsgGUID: 7xWWu7dATcG2TP9ibgmNPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="65337496" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 10:01:26 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smFrH-00000005TiG-32ah; Thu, 05 Sep 2024 20:01:23 +0300 Date: Thu, 5 Sep 2024 20:01:23 +0300 From: Andy Shevchenko To: Thomas Gleixner , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] x86/cpu: Mark flag_is_changeable_p() with __maybe_unused Message-ID: References: <20240905165859.254387-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905165859.254387-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Sep 05, 2024 at 07:58:58PM +0300, Andy Shevchenko wrote: > When flag_is_changeable_p() is unused, it prevents kernel builds > with clang, `make W=1` and CONFIG_WERROR=y: > > arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function] > 351 | static inline int flag_is_changeable_p(u32 flag) > | ^~~~~~~~~~~~~~~~~~~~ > > Fix this by marking it with __maybe_unused. > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for W=1 build"). ...and it should be done for 64-bit case. -- With Best Regards, Andy Shevchenko