From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v4 1/1] x86/cpu: Make sure flag_is_changeable_p() is always being used
Date: Fri, 8 Nov 2024 17:31:56 +0200 [thread overview]
Message-ID: <Zy4u7ByPh7WOnpdv@smile.fi.intel.com> (raw)
In-Reply-To: <Zy4rw-yx0JL7_-lk@smile.fi.intel.com>
On Fri, Nov 08, 2024 at 05:18:27PM +0200, Andy Shevchenko wrote:
> On Fri, Nov 08, 2024 at 04:13:05PM +0100, H. Peter Anvin wrote:
> > On November 8, 2024 3:11:46 PM GMT+01:00, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > >When flag_is_changeable_p() is unused, it prevents kernel builds
> > >with clang, `make W=1` and CONFIG_WERROR=y:
> > >
> > >arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
> > > 351 | static inline int flag_is_changeable_p(u32 flag)
> > > | ^~~~~~~~~~~~~~~~~~~~
> > >
> > >Fix this by moving core around to make sure flag_is_changeable_p() is
> > >always being used.
> > >
> > >See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > >inline functions for W=1 build").
> > >
> > >While at it, fix the argument type to be unsigned long, although it currently
> > >only runs in 32-bit cases.
...
> > It's good that you are changing the return type, but we need to be consistent
> > and change f1, f2 to match. At the same time, I suggest changing the return
> > type to bool.
>
> Ah, that makes sense!
All addressed in v5:
20241108153105.1578186-1-andriy.shevchenko@linux.intel.com
You are in Cc there.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-11-08 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 14:11 [PATCH v4 1/1] x86/cpu: Make sure flag_is_changeable_p() is always being used Andy Shevchenko
2024-11-08 15:13 ` H. Peter Anvin
2024-11-08 15:18 ` Andy Shevchenko
2024-11-08 15:31 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy4u7ByPh7WOnpdv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox