From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 23592329394; Wed, 3 Dec 2025 15:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776988; cv=none; b=FdtbQwv/2nzSyjzmpjrn+VYyELEWuSLT4PtlbyDzzxpuGaXNVSfOeJhEndHi8/Oi9X/xUfHz6C+WVgsQxw0HHdP1wtaCEbxXKXVPvhC6HT8IEuxMOCyeIxoQvsTkHuZrywD80DjgbNqilwKCUY1ueVIgf6L6uS+DWmB4gjnr/zg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764776988; c=relaxed/simple; bh=O9kytA0BZ9FXMyGNk8qiouCqe9HWVGIJIkYFlw65JR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SrSFC1yroQEbNJQB/4WQm6ylQS7vgrgcCqjloxOc7lrbA3xjGAVhXdZINdVq47SpWtBMTh/g4oERWcn/i1SP8x9qE8azAOdF3RDNMafe0edXYBx0FX8jmftDJRFe3BYxvlirBbgDy1uQLTIqGUQgLLxmZV1y1G0wLuyMDBrRwbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35F2A339; Wed, 3 Dec 2025 07:49:37 -0800 (PST) Received: from [10.57.45.67] (unknown [10.57.45.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A35FC3F59E; Wed, 3 Dec 2025 07:49:39 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 15:49:31 +0000 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 1/3] iommu/arm-smmu-v3: Add device-tree support for CMDQV driver To: Ashish Mhetre , will@kernel.org, nicolinc@nvidia.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, thierry.reding@gmail.com, jonathanh@nvidia.com, vdumpa@nvidia.com, jgg@ziepe.ca, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org, joro@8bytes.org, robh@kernel.org, kernel test robot References: <20251201163219.3237266-2-amhetre@nvidia.com> <202512031601.IpliwbHW-lkp@intel.com> <47684b91-7c0f-4260-abfd-2795fdaa2b31@nvidia.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: <47684b91-7c0f-4260-abfd-2795fdaa2b31@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-12-03 11:04 am, Ashish Mhetre wrote: > > On 12/3/2025 2:05 PM, kernel test robot wrote: >> External email: Use caution opening links or attachments >> >> >> Hi Ashish, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on next-20251201] >> [also build test ERROR on v6.18] >> [cannot apply to robh/for-next linus/master v6.18 v6.18-rc7 v6.18-rc6] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url:    https://github.com/intel-lab-lkp/linux/commits/Ashish-Mhetre/ >> iommu-arm-smmu-v3-Add-device-tree-support-for-CMDQV- >> driver/20251202-003517 >> base:   next-20251201 >> patch link:    https://lore.kernel.org/r/20251201163219.3237266-2- >> amhetre%40nvidia.com >> patch subject: [PATCH V3 1/3] iommu/arm-smmu-v3: Add device-tree >> support for CMDQV driver >> config: arm64-allmodconfig (https://download.01.org/0day-ci/ >> archive/20251203/202512031601.IpliwbHW-lkp@intel.com/config) >> compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project >> cd708029e0b2869e80abe31ddb175f7c35361f90) >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/ >> archive/20251203/202512031601.IpliwbHW-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new >> version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202512031601.IpliwbHW- >> lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >>>> ld.lld: error: duplicate symbol: init_module >>     >>> defined at arm-smmu-v3.c >>     >>>            drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.o: >> (init_module) >>     >>> defined at tegra241-cmdqv.c >>     >>>            drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.o: >> (.init.text+0x4) >> -- >>>> ld.lld: error: duplicate symbol: cleanup_module >>     >>> defined at arm-smmu-v3.c >>     >>>            drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.o: >> (cleanup_module) >>     >>> defined at tegra241-cmdqv.c >>     >>>            drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.o: >> (.exit.text+0x4) > > Hi Nic, Robin, > > How do you suggest fixing this? Is it fine to compile tegra241-cmdqv as > separate module > and export tegra241_cmdqv_probe() to fix this warning? As Jon just pointed out, the issue is using module_platform_driver(), which is unnecessary anyway since this is not a driver; nor is it even a module, it's just some extra code that can be included in the arm_smmu_v3 driver, and will be integral to the arm_smmu_v3.ko module if built as a such. You could sanity-check the compatible of the phandle target in tegra_cmdqv_dt_probe() if you feel like you should do more than just blindly trust the DT, but either way trying to register a dummy platform driver that won't bind to anything is pointless. > I am using GCC compiler and was not able to reproduce this with W=1 build. This will be happening with CONFIG_ARM_SMMU_V3=m. Thanks, Robin. > > Thanks, > Ashish Mhetre > >> -- >> 0-DAY CI Kernel Test Service >> https://github.com/intel/lkp-tests/wiki