From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46970202F9A for ; Fri, 23 May 2025 14:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748010912; cv=none; b=seNhxK6gopDB5Yu7GPBT2XafkngjI9/nlz8S7oAErB1lQk4zw5BnOyR/KfIHAdBrE4bx++7crfkR9J67afqLYtuXkXbuhR90vhwdhR3xd1fMNfQWuYgYDyh5S/gdqFlqx+O91yypOcgI9+fJiTnsCSlqMCpdcbrIVLnHQ51uy6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748010912; c=relaxed/simple; bh=rpziN1/05Zj11wUE9u4BbCxVKKTZOSPJiBdxOoe4oCQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=eT4cLg0jjNypPDnHx64McQ2zgU2bn43Eyc3ooEw1459fVtoKCrji4a6VEkhgP1iYQxu55rkWA6S+jg4yA/e3nnRbh4gjDtfl1RnG+Mo2vIunarwTqxd4xZ/zZ1xVa165HcZAlFchmmaEstU4b2I9DwSZg0dAdgbq9Bjh6EGk0QI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=h5HxEnBM; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="h5HxEnBM" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-232054aa634so60008635ad.3 for ; Fri, 23 May 2025 07:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748010909; x=1748615709; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=OHIXFovAEYPRF7pj3DkvXM+Wh6ry7OAZQdb2dc5cgKo=; b=h5HxEnBMLFtXwfbhJIrFcgjub7cbTN+bsDhe2XfuOF3zXAUJ3I9MVqFZnkxuiVLYK0 92EIbAp1IZ9prMcKfX9NFu00uOzKjQEOFR6oluvH2QSRi6tseyQ4T9ZMGiprFFbjouqm U+j8VEgLh16cOMXJx6ur0XufJD/XrIZebGiFg0Rq7JvPk7iExVENSz360OagoJMZSoGs zNcAJ53PVAnC96Gng5YxQ2Rs4HjMxaXeIku8RlLQZ0onJBlsp/gNJVwwXDw1owQBdKNl p0Zo9T9R4wdUEEyNDI/VAlXTUxQDlvSmRRsbzH9w+46C43JFZFqSMR++LAVHRXuS6fQa COSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748010909; x=1748615709; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OHIXFovAEYPRF7pj3DkvXM+Wh6ry7OAZQdb2dc5cgKo=; b=FgNQxJK2rawJddXtwczMGvdfI3kl6LT/ak6Sx0cbSe6ZYkDV0mnWh5Ap4X3NgvBVDo ghz5dMzZXKncox/itiStjnieDBl1k4PpT6EvW8D8UJ/a6aPGx6UvjNCCwIgveuChiwlN KCfBPtPS7Lzy5OeerKxrbqzpyRyeiOTzkKHL3C/zTKmUXPw60HuZY1S9PfEqaa6Daq+X 76PJx+0a07ZwSuFU/r6M/9po0q8sI4HFeD430gEeFsh0yMXU7U+j7X5MkFvHIjE3UVy9 TRjkbVK5vSH2wR48IGFVCyk4fQO5Zi2kytSYVG+DURLswmN4BjwwRNsdWOb4xWESPdVe Tv0w== X-Forwarded-Encrypted: i=1; AJvYcCXuOaXaRDwDpLmEIrWtPtN0stY6pMv/Z6WF1mfuaS+OIAIDAzakzEB7gJ1YYT0iwIt6iAzz@lists.linux.dev X-Gm-Message-State: AOJu0YwxS+wiQSW9ZTF5uMxLyzbwgz9zBxQZo2eBnfPhozoBJvmMJMP/ IxuH8cCTdQQt9mZd/Ua7ZdIzNpFn7ZW5svnTiOatP94tgRGFFjeyfpGA7y9b0DzHTR5OaWuVM+e kGIzEyA== X-Google-Smtp-Source: AGHT+IFz7sb0nLy8RLNRfKCeKqRGA0z4OYWQ9Q5+lv5cIKJ3DXiQQbAp7L//6YajGR6GltgQpVeH/+sDQGY= X-Received: from plka13.prod.google.com ([2002:a17:903:f8d:b0:231:def0:d268]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:41c7:b0:224:1221:1ab4 with SMTP id d9443c01a7336-231de317b43mr439457305ad.22.1748010908457; Fri, 23 May 2025 07:35:08 -0700 (PDT) Date: Fri, 23 May 2025 07:35:03 -0700 In-Reply-To: <20250523043935.2009972-4-kees@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250523043251.it.550-kees@kernel.org> <20250523043935.2009972-4-kees@kernel.org> Message-ID: Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches From: Sean Christopherson To: Kees Cook Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , "Ilpo =?utf-8?B?SsOkcnZpbmVu?=" , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Mike Rapoport , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, "Gustavo A. R. Silva" , Christoph Hellwig , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="us-ascii" On Thu, May 22, 2025, Kees Cook wrote: > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 921c1c783bc1..72f13d643fca 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -420,7 +420,7 @@ static u64 kvm_steal_clock(int cpu) > return steal; > } > > -static inline void __set_percpu_decrypted(void *ptr, unsigned long size) > +static __always_inline void __set_percpu_decrypted(void *ptr, unsigned long size) I'd rather drop the "inline" and explicitly mark this "__init". There's value in documenting and enforcing that memory is marked decrypted/shared only during boot. > { > early_set_memory_decrypted((unsigned long) ptr, size); > }