From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0AE9279903 for ; Wed, 28 May 2025 10:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748428687; cv=none; b=UcqWm+JvxRbl6RANlBfzZAxyBMyCyN4AZDGy3z9wY8/spz3AKbFQNZfY9sXe6614A72ICzS7TT8nXiW5nZQ8VVJYU9cKWmnU14TtA3yFqeedbW2nxm4FTeMaaPfan023WBkC7XyvYaFIrmyGv023CSzXf7nx6IChOdzZ9nUx9rA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748428687; c=relaxed/simple; bh=f88538q2yu07+QCvEaeEz9oVquJwFySRVSt/ENxM+xU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MqnPO76f8UuVV6bvIZs4/hMrzqbVbUrbCTyewKNaCn3toke0QmVgLQM2nsGj5Kh91djV8NaoVvc68NcofFzYDrfN1gcHa3FrsahurZBZnHc0bZeHdXXPPIwiqH7cozWvng4+n4RicmvKbKUMAW7qxFfVM1W8H5vswKSEq+W6iww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OHS6y4oy; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OHS6y4oy" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-3a4e1c6c68bso1293883f8f.0 for ; Wed, 28 May 2025 03:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748428684; x=1749033484; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IeeR9yH0GpAyOFZydrFxToBZKNrKT1e0eUyjOqJKqG0=; b=OHS6y4oysf5kjAXxKrehnNHcGEuOo7Qx+WjXVqvUQpNp6Gx2LTNKrgY8mlpz2kf4B2 6QhUFQ0qTWHeyu/iyccAy4NyVDeNP5L3ABR4YYzzSwit90Us3hnb/T7ULj/kDF2CVmcl NmJ6kUp3gnuUdM5hiXH2K+vrJPVioEz3HeafkaFkYERqc7YbiaYn3XtvzbZ7mMTTfo4a LkXfwZkELGsu1qxF6obTxTDAuMRP0eIgfmSpN2UbXJ0I9KHDY3mBtWzzBT/PNRCU7HhY lja8R/+c3ieotC4gwuXNyxqhpz3bhJ8I3kiCpBH55sqGZSzU+h5MBubOZK96a06Vx78e JU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748428684; x=1749033484; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IeeR9yH0GpAyOFZydrFxToBZKNrKT1e0eUyjOqJKqG0=; b=mpGdQ3UL3eELK1WKKYXMM4i/dpitgRps0ZbmJv5FBeSGdw/wA3F+bLaJqfU3dNxqSB PW9vU5o2/16ApL7DNzthhTRVI1hRhm4WaZaULlBBQgOoWXGFyzL0Rf9Ii58lpLMKASCT Yh6R5eGDaLZ8kr6Rqq4BV3ck3xH8+39dk3owr981gQmXY47d877J0UkidEUKML0q01Hk Mt2bYtxCxfRY4ARxY2/HxcqfTVh3KE3d+QlkfUv7hHmiAEKmtPuwtU2lhM3eZzf/wasF TouwM0yaYs98NlmzfNCWUuxI1ftP3te865ZcHg0RTf0ljckhwRDpiMzHt8RR6cAVT2WB 2qiQ== X-Forwarded-Encrypted: i=1; AJvYcCV0TjxR0qvnNM44cz3p+kkWPBacDDMfhNluFzBthkYfCwO68IGNf90+e9GDs7/jEokFssPq@lists.linux.dev X-Gm-Message-State: AOJu0YxHATenodKTQcbkb/+NpVQqPJiv0ttc6Yu6FkDG8pZYBATzx0Ez hyVU+vp+UrPQkA1y4L9sXjIk/qSXsrjH49CCD40we7ZvzwUNqr63klg5GlGDXqZo/326d3F2oPO Lgjug7e/nQe16OwyQLg== X-Google-Smtp-Source: AGHT+IEQyiB/rjNjbMrROAYgPHAOQltkjwgoUsDbxSNhCEmiFFBD4KxkcRnm6cL1n1mzqucg+R5Lc+Nr+C90dyo= X-Received: from wmbdv21.prod.google.com ([2002:a05:600c:6215:b0:450:5dbe:5f11]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:5f8b:0:b0:3a4:c95f:c1d1 with SMTP id ffacd0b85a97d-3a4cb428313mr13345804f8f.4.1748428683991; Wed, 28 May 2025 03:38:03 -0700 (PDT) Date: Wed, 28 May 2025 10:38:01 +0000 In-Reply-To: <20250524-cstr-core-v10-0-6412a94d9d75@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250524-cstr-core-v10-0-6412a94d9d75@gmail.com> Message-ID: Subject: Re: [PATCH v10 0/5] rust: replace kernel::str::CStr w/ core::ffi::CStr From: Alice Ryhl To: Tamir Duberstein Cc: Michal Rostecki , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Andreas Hindborg , Trevor Gross , Brendan Higgins , David Gow , Rae Moar , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Luis Chamberlain , Russ Weight , FUJITA Tomonori , Rob Herring , Saravana Kannan , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Arnd Bergmann , Jens Axboe , Benno Lossin , "Krzysztof =?utf-8?Q?Wilczy=C5=84ski?=" , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, llvm@lists.linux.dev, linux-pci@vger.kernel.org, nouveau@lists.freedesktop.org, linux-block@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Sat, May 24, 2025 at 04:33:00PM -0400, Tamir Duberstein wrote: > This picks up from Michal Rostecki's work[0]. Per Michal's guidance I > have omitted Co-authored tags, as the end result is quite different. > > Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorovsky@protonmail.com/t/#u [0] > Closes: https://github.com/Rust-for-Linux/linux/issues/1075 > > Signed-off-by: Tamir Duberstein Overall LGTM, thanks! Left a few comments on individual patches, but I can probably give a RB when those a fixed. :) Alice