From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hans de Goede <hansg@kernel.org>
Cc: LiangCheng Wang <zaq14760@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, llvm@lists.linux.dev
Subject: Re: [PATCH v6] staging: media: atomisp: apply clang-format and fix checkpatch.pl errors
Date: Fri, 27 Jun 2025 19:17:20 +0300 [thread overview]
Message-ID: <aF7EEAxXsurLvIt9@smile.fi.intel.com> (raw)
In-Reply-To: <e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org>
On Fri, Jun 27, 2025 at 06:05:08PM +0200, Hans de Goede wrote:
> On 27-Jun-25 4:56 PM, LiangCheng Wang wrote:
...
> for (i = 0; i < count; i++) {
> - err = i2c_smbus_write_byte_data(client, reglist[i].reg, reglist[i].val);
> + err = i2c_smbus_write_byte_data(client, reglist[i].reg,
> + reglist[i].val);
> if (err) {
> - dev_err(&client->dev, "write error: wrote 0x%x to offset 0x%x error %d",
>
> The original line here had a length below 100 chars, so it was fine
> and log messages are allowed to go over the length limit
Actually I tend to agree with clang-format on this case and that's why:
until V4L2 becomes less pedantic and fanatic about 80 characters
limit, the 100 is not applicable for this driver to be moved under
their umbrella.
> + dev_err(&client->dev,
> + "write error: wrote 0x%x to offset 0x%x error %d",
> reglist[i].val, reglist[i].reg, err);
> return err;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-27 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 14:56 [PATCH v6] staging: media: atomisp: apply clang-format and fix checkpatch.pl errors LiangCheng Wang
2025-06-27 16:03 ` Andy Shevchenko
2025-06-27 16:05 ` Hans de Goede
2025-06-27 16:17 ` Andy Shevchenko [this message]
2025-06-28 3:16 ` 王良丞
2025-06-27 16:16 ` Dan Carpenter
2025-06-30 19:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF7EEAxXsurLvIt9@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=zaq14760@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).