From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2AB823D28B for ; Sat, 18 Oct 2025 17:02:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760806963; cv=none; b=Y6f2SFpFrVxdNKQdntq/UlKoXP972zCDEx6IUtig/Jkau/rzUfjkwIiaeQzDKsgRfdyuGtRzZ5hC3zg6eosgmQmYfC+2CkFUcnmTbqK0AMbRFFiDKWQLPK26DrLLPYiIlcePtl/lEzNOikhvzul/jf56/KQrqiiCIJZTaHRiu88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760806963; c=relaxed/simple; bh=K56Is2wx7UmVl17dRBrxY8Gx8J2Mj6XdngEuoaXN7is=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=csKQFKSCri90qfxM33TIKvIAAj9w5Evy81Zx1DKs0hKkbgwgA7DnW0aKP6CgCWKC0UxIpIsgiio33gHtft7o3k/vXvegBhkC2OOp0MpqGpmYMt3j/76eJBhOA5dQkgHWbRIFNkfvzJzvG2Q9v+EHvCXRx3C4TJTz9T+2uZfZeLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=v0RoKJ0x; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="v0RoKJ0x" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-471125c8bc1so33881825e9.3 for ; Sat, 18 Oct 2025 10:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760806960; x=1761411760; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QcEJMCPQNzNn4Sg/+enW3pY+1OtQDQh0FQ7gWamWR/8=; b=v0RoKJ0xlMggkrpgdZV8sJ+1WdBAHQTUItd+H0Cee0mRvn8j81/jUm21zJ+y6FTMX9 g2k6ecV7nbQEg2CHi7YHdu2NjgK4exWkNpuhCsK5MdmiwJV2ws20bskBD9yGV2G1yxvi I3It3Fjkncf0tr6lJQEYD5nKw0gh1FwjIPydM/s4RLDIJ22nV7xBEmYdoh6O9hsuhVp0 GTG0OaP8hs/iZDOYVaAyOz885YLHqk9hfUFpaFc4lTbP7iWv7bo3WlrZvCYflMm2r9cQ KDfqYhUTl9OjQAoM+9/IweG3fTnYzu5TCcBSsfnrqM03IasQBW3Ke073v/ZzJ9Ebaz81 mKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760806960; x=1761411760; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QcEJMCPQNzNn4Sg/+enW3pY+1OtQDQh0FQ7gWamWR/8=; b=j28nQM2vgazp4s/XnCPPt4EIMZtH//tYGkRyGUS//pJQTQxKl3pUYoYwhfJ0RmRzc2 mC0v7T/j6vNpsz8MpujdOZ0Lf4kaPl7I32NzrVfREgKssu19hcCZSqxiyLUkno1IRyDl 1r140mHlmo4u/J0cXXSpEcfalCcZxgKzGR7ZsMrbreEvLyLzKwIb1h7HUwJQ206kfJsA rJBnZJiwo5ZppvqyQP/0A45SjVnnGANvshY75l1l2Vvp3+915xYWOHeqb4uQdQTRXiGh pcljBLuRGUqytPhQ5v5c2m2Ot4xP0IP5jLQvx+iqFya+3sL9sJ5lAvAAslvCvENw9s66 vyHw== X-Forwarded-Encrypted: i=1; AJvYcCVOM6pdOAyADeY/nKot83f7b9wqBelCVgZ/NYeK8saFWARPJ0tkybCC+Lg1J19hpe5uuvFk@lists.linux.dev X-Gm-Message-State: AOJu0YyRGmnAayosV1TKQm9GQjpb26vulucEnVbPjq/d3/rrSNCj0bMz oTlyK2dDan+bq7K5wWxzAhQryQYnsziiR+HF8g8m9G2nOa+xWNwRXYyuWwXZnF2lQmjM8JNUuhD HZtziQnCKAgv0zl/hOg== X-Google-Smtp-Source: AGHT+IG+XONBGTsyrZA2w5nXoym2WOeMmXEjzuALKqECWR/nae42PSy1vCNDSBfzkw7eA04iBiPKoZnTCFnDy3g= X-Received: from wmwo28.prod.google.com ([2002:a05:600d:439c:b0:46e:6605:3ac2]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600d:6357:b0:46e:1a07:7bd5 with SMTP id 5b1f17b1804b1-47160987501mr15825585e9.29.1760806960228; Sat, 18 Oct 2025 10:02:40 -0700 (PDT) Date: Sat, 18 Oct 2025 17:02:39 +0000 In-Reply-To: <20251015-cstr-core-v17-0-dc5e7aec870d@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251015-cstr-core-v17-0-dc5e7aec870d@gmail.com> Message-ID: Subject: Re: [PATCH v17 00/11] rust: replace kernel::str::CStr w/ core::ffi::CStr From: Alice Ryhl To: Tamir Duberstein Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Luis Chamberlain , Russ Weight , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Christian Brauner , Alexander Viro , Jan Kara , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Jens Axboe , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Bjorn Helgaas , "Krzysztof =?utf-8?Q?Wilczy=C5=84ski?=" , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Wed, Oct 15, 2025 at 03:24:30PM -0400, Tamir Duberstein wrote: > This picks up from Michal Rostecki's work[0]. Per Michal's guidance I > have omitted Co-authored tags, as the end result is quite different. > > This series is intended to be taken through rust-next. The final patch > in the series requires some other subsystems' `Acked-by`s: > - drivers/android/binder/stats.rs: rust_binder. Alice, could you take a > look? > - rust/kernel/device.rs: driver-core. Already acked by gregkh. > - rust/kernel/firmware.rs: driver-core. Danilo, could you take a look? > - rust/kernel/seq_file.rs: vfs. Christian, could you take a look? > - rust/kernel/sync/*: locking-core. Boqun, could you take a look? > > Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorovsky@protonmail.com/t/#u [0] > Closes: https://github.com/Rust-for-Linux/linux/issues/1075 > > Signed-off-by: Tamir Duberstein You need a few more changes: diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs index 1e6c8c42fb3a..c1cfaeaa36a2 100644 --- a/rust/kernel/clk.rs +++ b/rust/kernel/clk.rs @@ -136,7 +136,7 @@ impl Clk { /// /// [`clk_get`]: https://docs.kernel.org/core-api/kernel-api.html#c.clk_get pub fn get(dev: &Device, name: Option<&CStr>) -> Result { - let con_id = name.map_or(ptr::null(), |n| n.as_ptr()); + let con_id = name.map_or(ptr::null(), |n| n.as_char_ptr()); // SAFETY: It is safe to call [`clk_get`] for a valid device pointer. // @@ -304,7 +304,7 @@ impl OptionalClk { /// [`clk_get_optional`]: /// https://docs.kernel.org/core-api/kernel-api.html#c.clk_get_optional pub fn get(dev: &Device, name: Option<&CStr>) -> Result { - let con_id = name.map_or(ptr::null(), |n| n.as_ptr()); + let con_id = name.map_or(ptr::null(), |n| n.as_char_ptr()); // SAFETY: It is safe to call [`clk_get_optional`] for a valid device pointer. // diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs index 10f1547ca9f1..466fb7f40762 100644 --- a/rust/kernel/configfs.rs +++ b/rust/kernel/configfs.rs @@ -157,7 +157,7 @@ pub fn new( unsafe { bindings::config_group_init_type_name( &mut (*place.get()).su_group, - name.as_ptr(), + name.as_char_ptr(), item_type.as_ptr(), ) }; diff --git a/rust/kernel/debugfs/entry.rs b/rust/kernel/debugfs/entry.rs index f99402cd3ba0..5de0ebc27198 100644 --- a/rust/kernel/debugfs/entry.rs +++ b/rust/kernel/debugfs/entry.rs @@ -2,8 +2,7 @@ // Copyright (C) 2025 Google LLC. use crate::debugfs::file_ops::FileOps; -use crate::ffi::c_void; -use crate::str::CStr; +use crate::prelude::*; use crate::sync::Arc; use core::marker::PhantomData; diff --git a/rust/kernel/regulator.rs b/rust/kernel/regulator.rs index b55a201e5029..65a4eb096cae 100644 --- a/rust/kernel/regulator.rs +++ b/rust/kernel/regulator.rs @@ -84,7 +84,7 @@ pub struct Error { pub fn devm_enable(dev: &Device, name: &CStr) -> Result { // SAFETY: `dev` is a valid and bound device, while `name` is a valid C // string. - to_result(unsafe { bindings::devm_regulator_get_enable(dev.as_raw(), name.as_ptr()) }) + to_result(unsafe { bindings::devm_regulator_get_enable(dev.as_raw(), name.as_char_ptr()) }) } /// Same as [`devm_enable`], but calls `devm_regulator_get_enable_optional` @@ -102,7 +102,9 @@ pub fn devm_enable(dev: &Device, name: &CStr) -> Result { pub fn devm_enable_optional(dev: &Device, name: &CStr) -> Result { // SAFETY: `dev` is a valid and bound device, while `name` is a valid C // string. - to_result(unsafe { bindings::devm_regulator_get_enable_optional(dev.as_raw(), name.as_ptr()) }) + to_result(unsafe { + bindings::devm_regulator_get_enable_optional(dev.as_raw(), name.as_char_ptr()) + }) } /// A `struct regulator` abstraction. @@ -268,7 +270,8 @@ pub fn get_voltage(&self) -> Result { fn get_internal(dev: &Device, name: &CStr) -> Result> { // SAFETY: It is safe to call `regulator_get()`, on a device pointer // received from the C code. - let inner = from_err_ptr(unsafe { bindings::regulator_get(dev.as_raw(), name.as_ptr()) })?; + let inner = + from_err_ptr(unsafe { bindings::regulator_get(dev.as_raw(), name.as_char_ptr()) })?; // SAFETY: We can safely trust `inner` to be a pointer to a valid // regulator if `ERR_PTR` was not returned. --