From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6916A258CD7 for ; Sat, 18 Oct 2025 19:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760816656; cv=none; b=o8ap+Eu3XRK9v5A7CZK+IrMNoeoo2/xGd1U4ZwRh2CPw5wLFhwLvWERdp+6ckolBFvI6ulVAIl284Nrhv6NP4i6iP7Rq47CistL4vqmqsFZoTSI4tHOPU4T4R2van1rjgKBJVdR61i/60nU181kX4lJJ3m8qg98mZVTotKpwqbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760816656; c=relaxed/simple; bh=IxGbQ+0oog6MEU2YUYCjRLsGaSp8M46wL1EyN+tTuJA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=lfdJ/gFyE+iYlg9LD7gzP6lbu+l1IPuODKyJ6XdJby3lavYdH0y6XJGCCo5mycxOdKuWHceA6h603Y5EJNXjzrBoFgqc/eBIEO91KyLRUM2y9r6j/1vWrUPiQADWPDGYjOmELsebKuBF0hJ3tGV/L4IBUELZWdbu3sop0OVuAF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D0RTNVoh; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D0RTNVoh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1760816655; x=1792352655; h=date:from:to:cc:subject:message-id:mime-version; bh=IxGbQ+0oog6MEU2YUYCjRLsGaSp8M46wL1EyN+tTuJA=; b=D0RTNVohoabOBH8grshm8XHWr+Wh/eijoev/nJwu3XKfGJbh5RIXCuFk 8ybD2XSRMChw5cL+sg0qdiqe0s9C1vgu5qGAiaNCb6xJEcDaLtGVLtlHk TCuIElB0nhfAG/SGQOYeREorsTejoVwibQycDrMIXqKcIxTbDZMH5dawn +96I7r7SxFuRpKi0YYtY7Ia6wHBPskFh8435m/nF6QSM3URCjYdcb8fL+ pLqM02uVoQjQKb5BJCML2jGDzHdaZUMOerk/Mo1du03/BLKKMW6zw8Saw uqqu286hkddnMY2PdxHq9whO8Wxcr9AI5/5txtDqlhqasDLEEryfOmFNK Q==; X-CSE-ConnectionGUID: Bnq9A6CNTy+wSjJMzeWCWA== X-CSE-MsgGUID: V993L49lSy+Xa3vCSPg2ng== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="74114573" X-IronPort-AV: E=Sophos;i="6.19,239,1754982000"; d="scan'208";a="74114573" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2025 12:44:14 -0700 X-CSE-ConnectionGUID: apqLdoj/Qaaf0a/9rbmSSw== X-CSE-MsgGUID: NUNJhOViRPG7nCoGuDZXSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,239,1754982000"; d="scan'208";a="182192273" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO ashevche-desk.local) ([10.245.244.194]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2025 12:44:12 -0700 Received: from andy by ashevche-desk.local with local (Exim 4.98.2) (envelope-from ) id 1vACqW-00000000xjT-2jcB; Sat, 18 Oct 2025 22:44:08 +0300 Date: Sat, 18 Oct 2025 22:44:08 +0300 From: Andy Shevchenko To: Justinien Bouron Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Andrew Morton , Baoquan He , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [resend, PATCH v2 1/1] kexec: Remove unused code in kimage_load_cma_segment() Message-ID: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Sep 23, 2025 at 10:50:55AM -0700, Justinien Bouron wrote: > On Tue, Sep 16, 2025 at 02:51:09PM +0200, Andy Shevchenko wrote: > > clang is not happy about set but unused variable: > > > > kernel/kexec_core.c:745:16: error: variable 'maddr' set but not used [-Werror,-Wunused-but-set-variable] > > 745 | unsigned long maddr; > > | ^ > > 1 error generated. > > > > Fix the compilation breakage (`make W=1` build) by removing unused variable. > > > > As Nathan noted, GCC 16 produces the similar warning; > > > > Fixes: f4fecb50d6e1 ("kexec_core: remove superfluous page offset handling in segment loading") > FYI the commit this patch is fixing (i.e. f4fecb50d6e1) is going to need a > second revision as well (I haven't submitted it yet, still working on it), this > means that your "Fixes:" tag will need to be changed again, requiring a 3rd > revision. > > I am not sure what is the proper way forward here. Should I: > - Send my v2, without fixing the unused variable and then you send your v3 > with the updated "Fixes:" tag pointing to my v2. > - OR fixing the unused variable in my v2 (i.e. "absorb" this patch in my > v2). Second is the best (integrate this fix into yours v2). > In the latter case, I am not sure how I am supposed to credit the work in this > case? Do I need to add another "Signed-off-by: Andy Shevchenko" besides mine? Just in the comment block (after the cutter '---' line and before the diff) in a free words. No need for any special tags for this in such a case. > I'm still learning the ropes on how to contribute through the mailing list so I > would be grateful if you could share your input on what's the proper way forward > here. -- With Best Regards, Andy Shevchenko