Re: [brauner-github:vfs-6.19.iomap 20/25] fs/iomap/buffered-io.c:870:37: error: incompatible pointer to integer conversion passing 'u64 *' (aka 'unsigned long long *') to parameter of type 'u64' (aka 'unsigned long long'); remove &

[Brian Foster <bfoster@redhat.com>]

On Tue, Oct 21, 2025 at 07:26:24AM +0800, kernel test robot wrote:
> tree:   https://github.com/brauner/linux.git vfs-6.19.iomap
> head:   d61f6a3dc4f623b16ed43dd6113f594403b35211
> commit: b50d39532fdab9126c794139babaec5798e79567 [20/25] iomap: optional zero range dirty folio processing
> config: x86_64-buildonly-randconfig-003-20251021 (https://download.01.org/0day-ci/archive/20251021/202510210751.8T3mTZMw-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251021/202510210751.8T3mTZMw-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202510210751.8T3mTZMw-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> fs/iomap/buffered-io.c:870:37: error: incompatible pointer to integer conversion passing 'u64 *' (aka 'unsigned long long *') to parameter of type 'u64' (aka 'unsigned long long'); remove & [-Wint-conversion]
>      870 |                 status = iomap_iter_advance(iter, &len);
>          |                                                   ^~~~
>    include/linux/iomap.h:251:53: note: passing argument to parameter 'count' here
>      251 | int iomap_iter_advance(struct iomap_iter *iter, u64 count);
>          |                                                     ^
>    1 error generated.
> 

Ugh.. I guess this is because I didn't have Joanne's "iomap: simplify
iomap_iter_advance()" locally. Something like the diff below should
address it. Note that I won't have time to test properly until tomorrow
so this is compile tested only, but pretty straightforward.

BTW I'm not aware if this was published anywhere before now in the v6.19
branch, so if there's a general branch that is preferred to use for
pending iomap work or whatever let me know and I'll move over to it.

Brian

--- 8< ---

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 72196e5021b1..a5a9caae602e 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -867,7 +867,9 @@ static int iomap_write_begin(struct iomap_iter *iter,
 	if (folio_pos(folio) > iter->pos) {
 		len = min_t(u64, folio_pos(folio) - iter->pos,
 				 iomap_length(iter));
-		status = iomap_iter_advance(iter, &len);
+		status = iomap_iter_advance(iter, len);
+		if (!status)
+			len = iomap_length(iter);
 		if (status || !len)
 			goto out_unlock;
 	}