Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

Brian Masney
2025-12-01T21:09:23Z

Hi Conor and Claudiu,

On Mon, Dec 01, 2025 at 06:09:25PM +0000, Conor Dooley wrote:
> On Mon, Dec 01, 2025 at 01:01:25PM -0500, Brian Masney wrote:
> > On Thu, Nov 27, 2025 at 10:11:12AM +0800, kernel test robot wrote:
> > > Hi Brian,
> > >
> > > kernel test robot noticed the following build errors:
> > >
> > > [auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]
> > >
> > > url: https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
> > > base: 92fd6e84175befa1775e5c0ab682938eca27c0b2
> > > patch link: https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
> > > patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
> > > config: loongarch-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/config)
> > > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202511270924.0uDTpEE9-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/clk/microchip/clk-core.c:12:10: fatal error: 'asm/traps.h' file not found
> > > 12 | #include <asm/traps.h>
> > > | ^~~~~~~~~~~~~
> > > 1 error generated.
> > >
> > > Kconfig warnings: (for reference only)
> > > WARNING: unmet direct dependencies detected for TSM
> > > Depends on [n]: VIRT_DRIVERS [=n]
> > > Selected by [y]:
> > > - PCI_TSM [=y] && PCI [=y]
> > >
> > >
> > > vim +12 drivers/clk/microchip/clk-core.c
> > >
> > > ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12 #include <asm/traps.h>
> > > ce6e1188465998 Purna Chandra Mandal 2016-05-13 13
> >
> > I only build tested this on arm64. I'll post a v2.
>
> MIPS I believe is where this is used.

So looking into this further, it looks like asm/traps.h is actually not
used by this driver, so I'll go ahead and drop that include in v2.

> Hmm, I think this is in a MAINTAINERS blind spot, Claudiu not CCed on
> it. We should probably do something about that. Can you CC him on v2?

Yes, I'll CC Claudiu. I don't see any existing entries in MAINTAINERS
where it looks like this driver would fit neatly.

Brian