Re: [PATCH v3 2/2] iio: adc: ltc2309: add support for ltc2305

Re: [PATCH v3 2/2] iio: adc: ltc2309: add support for ltc2305

[kernel test robot]

Hi Kyle,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 9448598b22c50c8a5bb77a9103e2d49f134c9578]

url:    https://github.com/intel-lab-lkp/linux/commits/Kyle-Hsieh/dt-bindings-adc-ltc2497-add-support-for-ltc2305/20260126-093339
base:   9448598b22c50c8a5bb77a9103e2d49f134c9578
patch link:    https://lore.kernel.org/r/20260126-add_ltc2305_driver-v3-2-951349a87f97%40gmail.com
patch subject: [PATCH v3 2/2] iio: adc: ltc2309: add support for ltc2305
config: i386-buildonly-randconfig-006-20260126 (https://download.01.org/0day-ci/archive/20260126/202601261441.M4qQzY72-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601261441.M4qQzY72-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601261441.M4qQzY72-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/adc/ltc2309.c:209:20: warning: variable 'chip_info' is uninitialized when used here [-Wuninitialized]
     209 |         indio_dev->name = chip_info->name;
         |                           ^~~~~~~~~
   drivers/iio/adc/ltc2309.c:195:43: note: initialize the variable 'chip_info' to silence this warning
     195 |         const struct ltc2309_chip_info *chip_info;
         |                                                  ^
         |                                                   = NULL
   1 warning generated.


vim +/chip_info +209 drivers/iio/adc/ltc2309.c

   192	
   193	static int ltc2309_probe(struct i2c_client *client)
   194	{
   195		const struct ltc2309_chip_info *chip_info;
   196		struct iio_dev *indio_dev;
   197		struct ltc2309 *ltc2309;
   198		int ret;
   199	
   200		indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*ltc2309));
   201		if (!indio_dev)
   202			return -ENOMEM;
   203	
   204		ltc2309 = iio_priv(indio_dev);
   205	
   206		ltc2309->dev = &indio_dev->dev;
   207		ltc2309->client = client;
   208	
 > 209		indio_dev->name = chip_info->name;
   210		indio_dev->modes = INDIO_DIRECT_MODE;
   211		indio_dev->channels = chip_info->channels;
   212		indio_dev->num_channels = chip_info->num_channels;
   213		indio_dev->info = &ltc2309_info;
   214	
   215		ret = devm_regulator_get_enable_read_voltage(&client->dev, "vref");
   216		if (ret < 0 && ret != -ENODEV)
   217			return dev_err_probe(ltc2309->dev, ret,
   218					     "failed to get vref voltage\n");
   219	
   220		ltc2309->vref_mv = ret == -ENODEV ? LTC2309_INTERNAL_REF_MV : ret / 1000;
   221	
   222		mutex_init(&ltc2309->lock);
   223	
   224		return devm_iio_device_register(&client->dev, indio_dev);
   225	}
   226	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH v3 2/2] iio: adc: ltc2309: add support for ltc2305

[Andy Shevchenko]

On Mon, Jan 26, 2026 at 02:22:21PM +0800, kernel test robot wrote:
> Hi Kyle,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on 9448598b22c50c8a5bb77a9103e2d49f134c9578]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Kyle-Hsieh/dt-bindings-adc-ltc2497-add-support-for-ltc2305/20260126-093339
> base:   9448598b22c50c8a5bb77a9103e2d49f134c9578
> patch link:    https://lore.kernel.org/r/20260126-add_ltc2305_driver-v3-2-951349a87f97%40gmail.com
> patch subject: [PATCH v3 2/2] iio: adc: ltc2309: add support for ltc2305
> config: i386-buildonly-randconfig-006-20260126 (https://download.01.org/0day-ci/archive/20260126/202601261441.M4qQzY72-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601261441.M4qQzY72-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601261441.M4qQzY72-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/iio/adc/ltc2309.c:209:20: warning: variable 'chip_info' is uninitialized when used here [-Wuninitialized]
>      209 |         indio_dev->name = chip_info->name;
>          |                           ^~~~~~~~~
>    drivers/iio/adc/ltc2309.c:195:43: note: initialize the variable 'chip_info' to silence this warning
>      195 |         const struct ltc2309_chip_info *chip_info;
>          |                                                  ^
>          |                                                   = NULL

This is so wrong advice!

>    1 warning generated.

...

The device_get_match_data() call is missing.

-- 
With Best Regards,
Andy Shevchenko