public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Zhao Mengmeng <zhaomzhao@126.com>
Cc: tj@kernel.org, void@manifault.com, changwoo@igalia.com,
	shuah@kernel.org, nathan@kernel.org,
	nick.desaulniers+lkml@gmail.com, morbo@google.com,
	justinstitt@google.com, sched-ext@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	bpf@vger.kernel.org, llvm@lists.linux.dev,
	zhaomengmeng@kylinos.cn
Subject: Re: [PATCH 0/3] tools/sched_ext: fix compilation issues
Date: Tue, 3 Mar 2026 08:50:54 +0100	[thread overview]
Message-ID: <aaaS3jirvQudUR4x@gpd4> (raw)
In-Reply-To: <20260303072317.76035-1-zhaomzhao@126.com>

On Tue, Mar 03, 2026 at 03:23:14PM +0800, Zhao Mengmeng wrote:
> From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
> 
> This series addresses compilation issues in the sched_ext (scx)
> tooling and selftests when using Clang 17.
> 
> 1. Add -fms-extensions flags to scheduler and selftests to avoid build
> warning like "declaration does not declare anything"
> 2. Use signed div for peek_dsq.bpf.c to avoid clang 17 crash.

I confirm this removes the annoying warnings and these options are used in
other BPF selftests as well, so looks good to me.

Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks!
-Andrea

> 
> Zhao Mengmeng (3):
>   tools/sched_ext: Add -fms-extensions to bpf build flags
>   selftests/sched_ext: Add -fms-extensions to bpf build flags
>   selftests/sched_ext: Fix peek_dsq.bpf.c compile error for clang 17
> 
>  tools/sched_ext/Makefile                         | 2 ++
>  tools/testing/selftests/sched_ext/Makefile       | 2 ++
>  tools/testing/selftests/sched_ext/peek_dsq.bpf.c | 4 ++--
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 
> -- 
> 2.43.0
> 

      parent reply	other threads:[~2026-03-03  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  7:23 [PATCH 0/3] tools/sched_ext: fix compilation issues Zhao Mengmeng
2026-03-03  7:23 ` [PATCH 1/3] tools/sched_ext: Add -fms-extensions to bpf build flags Zhao Mengmeng
2026-03-03  7:23 ` [PATCH 2/3] selftests/sched_ext: " Zhao Mengmeng
2026-03-03  7:23 ` [PATCH 3/3] selftests/sched_ext: Fix peek_dsq.bpf.c compile error for clang 17 Zhao Mengmeng
2026-03-03  7:50 ` Andrea Righi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaaS3jirvQudUR4x@gpd4 \
    --to=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=changwoo@igalia.com \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=sched-ext@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    --cc=zhaomengmeng@kylinos.cn \
    --cc=zhaomzhao@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox