From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Brendan Jackman <jackmanb@google.com>,
Arnd Bergmann <arnd@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] bug: shut up format attribute warning for clang as well
Date: Tue, 24 Mar 2026 13:26:13 +0200 [thread overview]
Message-ID: <acJ01RZ1UPdSnjyH@ashevche-desk.local> (raw)
In-Reply-To: <ca8b75f5-c342-469e-b596-510177863272@app.fastmail.com>
On Mon, Mar 23, 2026 at 09:56:31PM +0100, Arnd Bergmann wrote:
> On Mon, Mar 23, 2026, at 21:45, Andrew Morton wrote:
> > On Mon, 23 Mar 2026 16:38:14 +0100 "Arnd Bergmann" <arnd@arndb.de> wrote:
> >> On Mon, Mar 23, 2026, at 11:54, Brendan Jackman wrote:
> >> > On Fri Mar 20, 2026 at 9:14 PM UTC, Arnd Bergmann wrote:
> >> >
> >> > There is actually a superior fix for this warning that Andy Schevchenko
> >> > posted here (mine just happened to get merged first):
> >> >
> >> > https://lore.kernel.org/all/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com/T/#u
> >> >
> >> > Should we just switch over to that? Looks like it should work for both
> >> > compilers.
> >>
> >> Right, I tried that again and it works. I had confused it with the
> >> similar logic to disable the warning on va_format(), which is
> >> not that easy to avoid.
> >
> > What I think I'm hearing is that we should revert Brendan's
> > d36067d6ea00 ("bug: Hush suggest-attribute=format for __warn_printf()")
> > then apply Andy's
> > https://lore.kernel.org/all/20251208141618.2805983-1-andriy.shevchenko@linux.intel.com/T/#u,
> > yes?
> >
> > Could someone please prepare a suitably changelogged and tested patch
> > for that?
>
> I now sent the version that I had in my tree already as a v2
> of my patch. I tested this with gcc-16 and clang-22 in random
> configurations.
Thank you!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-24 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 21:14 [PATCH] bug: shut up format attribute warning for clang as well Arnd Bergmann
2026-03-21 0:08 ` Nathan Chancellor
2026-03-23 10:54 ` Brendan Jackman
2026-03-23 15:38 ` Arnd Bergmann
2026-03-23 20:45 ` Andrew Morton
2026-03-23 20:56 ` Arnd Bergmann
2026-03-24 11:26 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJ01RZ1UPdSnjyH@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jackmanb@google.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox