From: Thierry Reding <thierry.reding@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@nxp.com,
acpica-devel@lists.linux.dev, conor+dt@kernel.org,
devicetree@vger.kernel.org, ebiggers@kernel.org,
fredrik.markstrom@est.tech, jonathanh@nvidia.com,
krzk@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux@roeck-us.net, lkp@intel.com, llvm@lists.linux.dev,
miquel.raynal@bootlin.com, oe-kbuild-all@lists.linux.dev,
p.zabel@pengutronix.de, rafael@kernel.org,
robert.moore@intel.com, robh@kernel.org, smangipudi@nvidia.com
Subject: Re: [PATCH 04/12] i3c: master: Support ACPI enumeration
Date: Wed, 25 Mar 2026 11:59:12 +0100 [thread overview]
Message-ID: <acO_PUjS_VG07qcS@orome> (raw)
In-Reply-To: <20260324172215.31540-1-akhilrajeev@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Tue, Mar 24, 2026 at 10:52:15PM +0530, Akhil R wrote:
> On Tue, 24 Mar 2026 09:43:27 +0100, Alexandre Belloni wrote:
>
> ...
>
> >> #include <linux/acpi.h> is added in PATCH 03/12. The functions' prototypes
> >> are present in acpi.h. I think the bot checked this patch individually,
> >> or did I miss something?
> >>
> >
> > #include <acpi/acpi_bus.h> is behind an #ifdef in acpi.h and your code
> > is not.
>
> Thanks for pointing Alexandre and Guenter. I also noticed that we do not
> have stub functions for a few of the acpi_* functions in #else.
>
> Looks like I will have to guard calls to these functions under
> #ifdef CONFIG_ACPI.
Alternatively it might make sense to add the stubs in a separate patch.
I don't know if they were purposefully left out or nobody's ever run
into the lack of these before.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-03-25 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260318172820.13771-5-akhilrajeev@nvidia.com>
2026-03-22 17:47 ` [PATCH 04/12] i3c: master: Support ACPI enumeration kernel test robot
2026-03-23 18:42 ` Akhil R
2026-03-23 18:54 ` Guenter Roeck
2026-03-24 8:43 ` Alexandre Belloni
2026-03-24 17:22 ` Akhil R
2026-03-25 10:59 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acO_PUjS_VG07qcS@orome \
--to=thierry.reding@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=acpica-devel@lists.linux.dev \
--cc=akhilrajeev@nvidia.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=fredrik.markstrom@est.tech \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=robh@kernel.org \
--cc=smangipudi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox