Re: [trace:bootconfig/for-next 16/16] init/main.c:437:20: warning: stack frame size (4192) exceeds limit (2048) in 'bootconfig_apply_early_params'

[Breno Leitao <leitao@debian.org>]

On Wed, Mar 25, 2026 at 03:52:27PM +0900, Masami Hiramatsu wrote:

> >  > 437	static void __init bootconfig_apply_early_params(void)
> >    438	{
> >    439		char val_buf[COMMAND_LINE_SIZE];
> 
> Ah, this COMMAND_LINE_SIZE is too big to allocate it on stack.
> We need to make it as a static __initdata variable.

Ack, I will respin it. Thanks!

> Thank you,
> 
> >    440		struct xbc_node *knode, *root;
> >    441		const char *val;
> >    442	
> >    443		root = xbc_find_node("kernel");
> >    444		if (!root)
> >    445			return;
> >    446	
> >    447		/*
> >    448		 * Keys that do not match any early_param() handler are silently
> >    449		 * ignored — do_early_param() always returns 0.
> >    450		 */
> >    451		xbc_node_for_each_key_value(root, knode, val) {
> >    452			if (xbc_node_compose_key_after(root, knode, xbc_namebuf, XBC_KEYLEN_MAX) < 0)
> >    453				continue;
> >    454	
> >    455			if (!val) {

I also found that val cannot be NULL here, given
xbc_node_for_each_key_value() returns an empty string ("") instead of
NULL, so, I will remove this branch here as well.