From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E770E27702A for ; Wed, 20 Aug 2025 01:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755654871; cv=none; b=bCLgmmdx2GBnxNLJI79y1iLBuT1IiU3C9r50lwPAmFfxx3UQD+SmU1P2pNU1wERxGrLsk20B0/YM2tEViHBv/GEIK5U7GnQUjZG9ZuCoD0YS4doFqONFp0dSl31W5ZaixGUvae9nRfT/7xRezQhulJpeQoWZiJcBrt98XqKmxEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755654871; c=relaxed/simple; bh=0dS7Dvi8VpyLmp3azlPofNJqhmQ2Buq2f8WM9QeJlXk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S+0hhkyM7Qy94+WKHBLEb2SHe6pEYiUq+lKkneMhD5lK1WFyIdjXqGXvqTdD6K1ACTt9uvsuIkHkgqG2S4U3QOVRLRGOb8EzVNRmna9dZ8yLrGALy015MkyTaOj8/Ng388c9dc0VsFX7HEmJk4YAdTRtDkVR14PdRxm2KpOLYxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=pCVNV4T7; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="pCVNV4T7" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755654866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eahXrLInkrCA7eb/xYG4dx3o/yyl8ef/xSYb6rkODMY=; b=pCVNV4T7NVg27PHyW7dCE6EQ2iYGKoebYGF5nWklRLOs50SrZ29zYiPpwykLNVldlIPPMn 87ztk76Nit13NdGb9ZWJRSDNYFfWUOZKFw5jZhiBrrruzGrpH1szx7wUByV+Ot4Qwk7vGn ocmNnYPAKKPZj4SrKETmiDy4cbdnrV8= Date: Wed, 20 Aug 2025 09:54:21 +0800 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] panic: Clean up message about deprecated 'panic_print' parameter Content-Language: en-US To: kernel test robot , Petr Mladek , Feng Tang Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Steven Rostedt , Jonathan Corbet , linux-kernel@vger.kernel.org, paulmck@kernel.org, john.ogness@linutronix.de References: <202508200907.PsZ3geub-lkp@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <202508200907.PsZ3geub-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2025/8/20 09:31, kernel test robot wrote: > Hi Petr, > > kernel test robot noticed the following build errors: > > > > url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20250819-180717/Feng-Tang/lib-sys_info-handle-sys_info_mask-0-case/20250815-152131 > base: the 3th patch of https://lore.kernel.org/r/20250815071428.98041-4-feng.tang%40linux.alibaba.com > patch link: https://lore.kernel.org/r/aKRJKZHgcxyNF3y7%40pathway.suse.cz > patch subject: [PATCH] panic: Clean up message about deprecated 'panic_print' parameter > config: i386-buildonly-randconfig-004-20250820 (https://download.01.org/0day-ci/archive/20250820/202508200907.PsZ3geub-lkp@intel.com/config) > compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250820/202508200907.PsZ3geub-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202508200907.PsZ3geub-lkp@intel.com/ > > All errors (new ones prefixed by >>): > >>> kernel/panic.c:952:2: error: call to undeclared function 'panic_print_deprecated'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 952 | panic_print_deprecated(); > | ^ > kernel/panic.c:958:2: error: call to undeclared function 'panic_print_deprecated'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 958 | panic_print_deprecated(); > | ^ > 2 errors generated. Oops, panic_print_deprecated() is defined within the #ifdef CONFIG_PROC_SYSCTL block, but it's also called from panic_print_set() and panic_print_get(), which are outside of that block. So, we need to move the definition out of the block to a common scope where all its callers can see it. @Petr wdyt? Thanks, Lance > > > vim +/panic_print_deprecated +952 kernel/panic.c > > 949 > 950 static int panic_print_set(const char *val, const struct kernel_param *kp) > 951 { > > 952 panic_print_deprecated(); > 953 return param_set_ulong(val, kp); > 954 } > 955 >